From: Ido Schimmel <idosch@nvidia•com>
To: "Wysocki, Rafael J" <rafael.j.wysocki@intel•com>
Cc: Petr Machata <petrm@nvidia•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org, mlxsw@nvidia•com,
Lukasz Luba <lukasz.luba@arm•com>,
Daniel Lezcano <daniel.lezcano@linaro•org>,
Vadim Pasternak <vadimp@nvidia•com>
Subject: Re: [PATCH net 2/3] mlxsw: core_thermal: Fix driver initialization failure
Date: Tue, 18 Jun 2024 09:55:51 +0300 [thread overview]
Message-ID: <ZnEvdxPSQFSq8mDZ@shredder.mtl.com> (raw)
In-Reply-To: <d3c8f29c-22ca-4ece-8beb-ed14587bcaf0@intel.com>
On Mon, Jun 17, 2024 at 09:53:59PM +0200, Wysocki, Rafael J wrote:
> On 6/17/2024 6:56 PM, Petr Machata wrote:
> > From: Ido Schimmel <idosch@nvidia•com>
> >
> > Commit 31a0fa0019b0 ("thermal/debugfs: Pass cooling device state to
> > thermal_debug_cdev_add()") changed the thermal core to read the current
> > state of the cooling device as part of the cooling device's
> > registration. This is incompatible with the current implementation of
> > the cooling device operations in mlxsw, leading to initialization
> > failure with errors such as:
> >
> > mlxsw_spectrum 0000:01:00.0: Failed to register cooling device
> > mlxsw_spectrum 0000:01:00.0: cannot register bus device
>
> Is this still a problem after
>
> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=thermal&id=1af89dedc8a58006d8e385b1e0d2cd24df8a3b69
>
> which has been merged into 6.10-rc4?
No, cooling device registration does not fail after your patch.
However, I think it's still worth merging my patch since without it the
driver does not provide a valid initial state which should not happen.
Are you OK with us dropping this patch from v2 and targeting it instead
at net-next (with an updated commit message)?
Thanks
next prev parent reply other threads:[~2024-06-18 6:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 16:55 [PATCH net 0/3] mlxsw: Fixes Petr Machata
2024-06-17 16:56 ` [PATCH net 1/3] mlxsw: pci: Fix driver initialization with Spectrum-4 Petr Machata
2024-06-19 14:50 ` Simon Horman
2024-06-17 16:56 ` [PATCH net 2/3] mlxsw: core_thermal: Fix driver initialization failure Petr Machata
2024-06-17 19:53 ` Wysocki, Rafael J
2024-06-18 6:55 ` Ido Schimmel [this message]
2024-06-17 16:56 ` [PATCH net 3/3] mlxsw: spectrum_buffers: Fix memory corruptions on Spectrum-4 systems Petr Machata
2024-06-19 14:51 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZnEvdxPSQFSq8mDZ@shredder.mtl.com \
--to=idosch@nvidia$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lukasz.luba@arm$(echo .)com \
--cc=mlxsw@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=rafael.j.wysocki@intel$(echo .)com \
--cc=vadimp@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox