From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Yangtao Li <frank.li@vivo•com>
Cc: clement.leger@bootlin•com, andrew@lunn•ch, f.fainelli@gmail•com,
olteanv@gmail•com, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, ulli.kroll@googlemail•com,
linus.walleij@linaro•org, marcin.s.wojtas@gmail•com,
alexandre.torgue@foss•st.com, joabreu@synopsys•com,
mcoquelin.stm32@gmail•com, hkallweit1@gmail•com,
u.kleine-koenig@pengutronix•de, jacob.e.keller@intel•com,
justinstitt@google•com, sd@queasysnail•net, horms@kernel•org,
linux-renesas-soc@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-stm32@st-md-mailman•stormreply.com,
Maxime Chevallier <maxime.chevallier@bootlin•com>
Subject: Re: [net-next v3 3/9] net: ethernet: cortina: Convert to devm_clk_get_enabled()
Date: Tue, 27 Aug 2024 12:25:50 +0100 [thread overview]
Message-ID: <Zs23vqQn9zqOQ62S@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240827095712.2672820-4-frank.li@vivo.com>
On Tue, Aug 27, 2024 at 03:57:06AM -0600, Yangtao Li wrote:
> ret = register_netdev(netdev);
> if (ret)
> - goto unprepare;
> + return ret;
>
> return 0;
Same comment as per patch 1. At this point, I'm going to stop reviewing
your patches (because I don't want to waste what little time I'm able
to spend in front of the screen raising comments against the same issue
throughout a patch set) and I ask you to do your own review of your
series for this pattern - and also consider where using
PTR_ERR_OR_ZERO() may also be appropriate in any of your patches. See
that function's documentation in linux/err.h.
Please wait at least 24 hours before reposting.
Thanks.
--
*** please note that I probably will only be occasionally responsive
*** for an unknown period of time due to recent eye surgery making
*** reading quite difficult.
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-08-27 11:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 9:57 [net-next v3 0/9] net: convert to devm_clk_get_enabled() and devm_clk_get_optional_enabled() Yangtao Li
2024-08-27 9:57 ` [net-next v3 1/9] net: stmmac: dwmac-intel-plat: Convert to devm_clk_get_enabled() Yangtao Li
2024-08-27 11:20 ` Russell King (Oracle)
2024-08-27 14:51 ` Simon Horman
2024-08-27 9:57 ` [net-next v3 2/9] net: stmmac: platform: Convert to devm_clk_get_enabled() and devm_clk_get_optional_enabled() Yangtao Li
2024-08-27 14:53 ` Simon Horman
2024-08-29 7:22 ` Serge Semin
2024-08-27 9:57 ` [net-next v3 3/9] net: ethernet: cortina: Convert to devm_clk_get_enabled() Yangtao Li
2024-08-27 10:53 ` Jonathan Cameron
2024-08-27 11:25 ` Russell King (Oracle) [this message]
2024-08-27 9:57 ` [net-next v3 4/9] net: mdio: hisi-femac: " Yangtao Li
2024-08-27 10:50 ` Jonathan Cameron
2024-08-27 9:57 ` [net-next v3 5/9] net: dsa: rzn1_a5psw: " Yangtao Li
2024-08-27 12:03 ` Geert Uytterhoeven
2024-08-27 9:57 ` [net-next v3 6/9] net: ethernet: broadcom: bcm63xx_enet: " Yangtao Li
2024-08-27 10:57 ` Jonathan Cameron
2024-08-27 9:57 ` [net-next v3 7/9] net: ethernet: marvell: mvneta: " Yangtao Li
2024-08-27 10:58 ` Jonathan Cameron
2024-08-27 9:57 ` [net-next v3 8/9] net: mvpp2: Convert to devm_clk_get_enabled() and devm_clk_get_optional_enabled() Yangtao Li
2024-08-27 11:09 ` Jonathan Cameron
2024-08-28 6:25 ` Marcin Wojtas
2024-08-28 7:12 ` Geert Uytterhoeven
2024-08-28 13:39 ` Marcin Wojtas
2024-08-27 14:55 ` Simon Horman
2024-08-27 9:57 ` [net-next v3 9/9] net: marvell: pxa168_eth: Convert to devm_clk_get_enabled() Yangtao Li
2024-08-27 11:11 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zs23vqQn9zqOQ62S@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew@lunn$(echo .)ch \
--cc=clement.leger@bootlin$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=frank.li@vivo$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=justinstitt@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=marcin.s.wojtas@gmail$(echo .)com \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=sd@queasysnail$(echo .)net \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=ulli.kroll@googlemail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox