From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: 韦尚娟 <weishangjuan@eswincomputing•com>
Cc: devicetree@vger•kernel.org, andrew+netdev@lunn•ch,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
robh@kernel•org, krzk+dt@kernel•org, conor+dt@kernel•org,
netdev@vger•kernel.org, pabeni@redhat•com,
mcoquelin.stm32@gmail•com, alexandre.torgue@foss•st.com,
vladimir.oltean@nxp•com, yong.liang.choong@linux•intel.com,
anthony.l.nguyen@intel•com,
prabhakar.mahadev-lad.rj@bp•renesas.com, jan.petrous@oss•nxp.com,
jszhang@kernel•org, inochiama@gmail•com, 0x1207@gmail•com,
boon.khai.ng@altera•com, linux-kernel@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, ningyu@eswincomputing•com,
linmin@eswincomputing•com, lizhi2@eswincomputing•com,
pinkesh.vaghela@einfochips•com
Subject: Re: Re: [PATCH v7 2/2] ethernet: eswin: Add eic7700 ethernet driver
Date: Tue, 23 Sep 2025 10:09:06 +0100 [thread overview]
Message-ID: <aNJjshm4Z8H2Z8_V@shell.armlinux.org.uk> (raw)
In-Reply-To: <30080c70.16e1.199748921d3.Coremail.weishangjuan@eswincomputing.com>
On Tue, Sep 23, 2025 at 11:06:08AM +0800, 韦尚娟 wrote:
> In the current eic7700_dwmac glue driver, the regmap_read()/write()
> operations(for phy_ctrl1, axi_lp_ctrl1, and the RX/TX delay registers))are
> performed directly in the probe() function. Would it be cleaner to move these
> register configurations into the init() callback instead, so that they are
> also reapplied during resume()?
This is a question I can't answer definitively as I don't know what
happens during a suspend on your hardware, and thus which registers
are lost / reset by the time the system resumes. So I can only give
the obvious guidance.
If the settings in the delay registers are lost over a suspend/resume
then they need to be re-initialised after resume.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-09-23 9:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 8:56 [PATCH v7 0/2] Add driver support for Eswin eic7700 SoC ethernet controller weishangjuan
2025-09-18 8:59 ` [PATCH v7 1/2] dt-bindings: ethernet: eswin: Document for EIC7700 SoC weishangjuan
2025-09-18 10:39 ` Rob Herring (Arm)
2025-10-14 8:53 ` Bo Gan
2025-10-14 10:00 ` 李志
2025-09-18 9:00 ` [PATCH v7 2/2] ethernet: eswin: Add eic7700 ethernet driver weishangjuan
2025-09-18 16:22 ` Andrew Lunn
2025-09-18 17:16 ` Russell King (Oracle)
2025-09-23 3:06 ` 韦尚娟
2025-09-23 9:09 ` Russell King (Oracle) [this message]
2025-09-30 10:01 ` 李志
2025-09-23 16:33 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNJjshm4Z8H2Z8_V@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=0x1207@gmail$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=boon.khai.ng@altera$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=inochiama@gmail$(echo .)com \
--cc=jan.petrous@oss$(echo .)nxp.com \
--cc=jszhang@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linmin@eswincomputing$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=lizhi2@eswincomputing$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ningyu@eswincomputing$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pinkesh.vaghela@einfochips$(echo .)com \
--cc=prabhakar.mahadev-lad.rj@bp$(echo .)renesas.com \
--cc=robh@kernel$(echo .)org \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=weishangjuan@eswincomputing$(echo .)com \
--cc=yong.liang.choong@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox