From: Maxime Chevallier <maxime.chevallier@bootlin•com>
To: weishangjuan@eswincomputing•com, devicetree@vger•kernel.org,
andrew+netdev@lunn•ch, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, robh@kernel•org, krzk+dt@kernel•org,
conor+dt@kernel•org, netdev@vger•kernel.org, pabeni@redhat•com,
mcoquelin.stm32@gmail•com, alexandre.torgue@foss•st.com,
vladimir.oltean@nxp•com, rmk+kernel@armlinux•org.uk,
yong.liang.choong@linux•intel.com, anthony.l.nguyen@intel•com,
prabhakar.mahadev-lad.rj@bp•renesas.com, jan.petrous@oss•nxp.com,
jszhang@kernel•org, inochiama@gmail•com, 0x1207@gmail•com,
boon.khai.ng@altera•com, linux-kernel@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org
Cc: ningyu@eswincomputing•com, linmin@eswincomputing•com,
lizhi2@eswincomputing•com, pinkesh.vaghela@einfochips•com
Subject: Re: [PATCH v7 2/2] ethernet: eswin: Add eic7700 ethernet driver
Date: Tue, 23 Sep 2025 22:03:09 +0530 [thread overview]
Message-ID: <bbcca781-9ac4-4eec-b3fb-ff4e01950127@bootlin.com> (raw)
In-Reply-To: <20250918090026.3280-1-weishangjuan@eswincomputing.com>
Hi,
On 18/09/2025 14:30, weishangjuan@eswincomputing•com wrote:
> From: Shangjuan Wei <weishangjuan@eswincomputing•com>
>
> Add Ethernet controller support for Eswin's eic7700 SoC. The driver
> implements hardware initialization, clock configuration, delay
> adjustment functions based on DWC Ethernet controller, and supports
> device tree configuration and platform driver integration.
>
> Signed-off-by: Zhi Li <lizhi2@eswincomputing•com>
> Signed-off-by: Shangjuan Wei <weishangjuan@eswincomputing•com>
> ---
> drivers/net/ethernet/stmicro/stmmac/Kconfig | 11 +
> drivers/net/ethernet/stmicro/stmmac/Makefile | 1 +
> .../ethernet/stmicro/stmmac/dwmac-eic7700.c | 230 ++++++++++++++++++
> 3 files changed, 242 insertions(+)
> create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> index 67fa879b1e52..a13b15ce1abd 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -67,6 +67,17 @@ config DWMAC_ANARION
>
> This selects the Anarion SoC glue layer support for the stmmac driver.
>
> +config DWMAC_EIC7700
> + tristate "Support for Eswin eic7700 ethernet driver"
> + select CRC32
> + select MII
Seems like CRC32 and MII are already selected by STMMAC_ETH. I guess
this is inspired by CONFIG_DWMAC_DWC_QOS_ETH that also seems to have
these unnecessary dependencies.
Maxime
prev parent reply other threads:[~2025-09-23 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 8:56 [PATCH v7 0/2] Add driver support for Eswin eic7700 SoC ethernet controller weishangjuan
2025-09-18 8:59 ` [PATCH v7 1/2] dt-bindings: ethernet: eswin: Document for EIC7700 SoC weishangjuan
2025-09-18 10:39 ` Rob Herring (Arm)
2025-10-14 8:53 ` Bo Gan
2025-10-14 10:00 ` 李志
2025-09-18 9:00 ` [PATCH v7 2/2] ethernet: eswin: Add eic7700 ethernet driver weishangjuan
2025-09-18 16:22 ` Andrew Lunn
2025-09-18 17:16 ` Russell King (Oracle)
2025-09-23 3:06 ` 韦尚娟
2025-09-23 9:09 ` Russell King (Oracle)
2025-09-30 10:01 ` 李志
2025-09-23 16:33 ` Maxime Chevallier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbcca781-9ac4-4eec-b3fb-ff4e01950127@bootlin.com \
--to=maxime.chevallier@bootlin$(echo .)com \
--cc=0x1207@gmail$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=boon.khai.ng@altera$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=inochiama@gmail$(echo .)com \
--cc=jan.petrous@oss$(echo .)nxp.com \
--cc=jszhang@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linmin@eswincomputing$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=lizhi2@eswincomputing$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ningyu@eswincomputing$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pinkesh.vaghela@einfochips$(echo .)com \
--cc=prabhakar.mahadev-lad.rj@bp$(echo .)renesas.com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
--cc=robh@kernel$(echo .)org \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=weishangjuan@eswincomputing$(echo .)com \
--cc=yong.liang.choong@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox