From: Hangbin Liu <liuhangbin@gmail•com>
To: Tonghao Zhang <tonghao@bamaicloud•com>
Cc: netdev@vger•kernel.org, Jay Vosburgh <jv@jvosburgh•net>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Simon Horman <horms@kernel•org>, Jonathan Corbet <corbet@lwn•net>,
Andrew Lunn <andrew+netdev@lunn•ch>,
Steven Rostedt <rostedt@goodmis•org>,
Masami Hiramatsu <mhiramat@kernel•org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios•com>,
Nikolay Aleksandrov <razor@blackwall•org>,
Zengbing Tu <tuzengbing@didiglobal•com>,
Antoine Tenart <atenart@kernel•org>
Subject: Re: [net-next v8 3/3] net: bonding: send peer notify when failure recovery
Date: Wed, 15 Oct 2025 03:36:18 +0000 [thread overview]
Message-ID: <aO8WsjvT_kY_rL2v@fedora> (raw)
In-Reply-To: <3993652dc093fffa9504ce1c2448fb9dea31d2d2.1751031306.git.tonghao@bamaicloud.com>
On Fri, Jun 27, 2025 at 09:49:30PM +0800, Tonghao Zhang wrote:
> +static void ad_cond_set_peer_notif(struct port *port)
> +{
> + struct bonding *bond = port->slave->bond;
> +
> + if (bond->params.broadcast_neighbor && rtnl_trylock()) {
Hi Tonghao,
When do our internal review, Antoine pointed that this rtnl_trylock() may
fail and cause the notify not send. The other places of bonding using
workqueues to reschedule when the rtnl_trylock() failed. Do you think
if we should also do some similar thing to avoid notify failed?
Thanks
Hangbin
> + bond->send_peer_notif = bond->params.num_peer_notif *
> + max(1, bond->params.peer_notif_delay);
> + rtnl_unlock();
> + }
> +}
next prev parent reply other threads:[~2025-10-15 3:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 13:49 [net-next v8 0/3] add broadcast_neighbor for no-stacking networking arch Tonghao Zhang
2025-06-27 13:49 ` [net-next v8 1/3] net: bonding: add broadcast_neighbor option for 802.3ad Tonghao Zhang
2025-10-14 8:41 ` Jiri Slaby
2025-10-14 9:12 ` Jiri Slaby
2025-10-14 9:22 ` Jiri Slaby
2025-10-14 12:52 ` Tonghao Zhang
2025-10-15 5:31 ` Jiri Slaby
2025-06-27 13:49 ` [net-next v8 2/3] net: bonding: add broadcast_neighbor netlink option Tonghao Zhang
2025-09-23 2:07 ` Hangbin Liu
2025-09-23 8:32 ` Tonghao Zhang
2025-06-27 13:49 ` [net-next v8 3/3] net: bonding: send peer notify when failure recovery Tonghao Zhang
2025-10-15 3:36 ` Hangbin Liu [this message]
2025-10-15 13:29 ` Tonghao Zhang
2025-07-08 9:10 ` [net-next v8 0/3] add broadcast_neighbor for no-stacking networking arch patchwork-bot+netdevbpf
2025-09-24 2:23 ` Hangbin Liu
2025-09-28 4:11 ` Tonghao Zhang
2025-09-29 8:35 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO8WsjvT_kY_rL2v@fedora \
--to=liuhangbin@gmail$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=atenart@kernel$(echo .)org \
--cc=corbet@lwn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jv@jvosburgh$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mhiramat@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=tonghao@bamaicloud$(echo .)com \
--cc=tuzengbing@didiglobal$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox