From: Mohd Ayaan Anwar <mohd.anwar@oss•qualcomm.com>
To: "Russell King (Oracle)" <linux@armlinux•org.uk>
Cc: "Andrew Lunn" <andrew@lunn•ch>,
"Heiner Kallweit" <hkallweit1@gmail•com>,
"Alexandre Torgue" <alexandre.torgue@foss•st.com>,
"Alexis Lothoré" <alexis.lothore@bootlin•com>,
"Andrew Lunn" <andrew+netdev@lunn•ch>,
"Boon Khai Ng" <boon.khai.ng@altera•com>,
"Daniel Machon" <daniel.machon@microchip•com>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Furong Xu" <0x1207@gmail•com>,
"Jacob Keller" <jacob.e.keller@intel•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Jan Petrous (OSS)" <jan.petrous@oss•nxp.com>,
linux-arm-kernel@lists•infradead.org,
linux-stm32@st-md-mailman•stormreply.com,
"Maxime Chevallier" <maxime.chevallier@bootlin•com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail•com>,
netdev@vger•kernel.org, "Paolo Abeni" <pabeni@redhat•com>,
"Simon Horman" <horms@kernel•org>,
"Vladimir Oltean" <olteanv@gmail•com>,
"Yu-Chun Lin" <eleanor15x@gmail•com>
Subject: Re: [PATCH net-next 0/3] net: stmmac: phylink PCS conversion part 3 (dodgy stuff)
Date: Wed, 29 Oct 2025 02:42:39 +0530 [thread overview]
Message-ID: <aQExx0zXT5SvFxAk@oss.qualcomm.com> (raw)
In-Reply-To: <aP03aQLADMg-J_4W@shell.armlinux.org.uk>
Hi Russell,
On Sat, Oct 25, 2025 at 09:47:37PM +0100, Russell King (Oracle) wrote:
> Hi,
>
> This series is currently the last of the phylink PCS conversion for
> stmmac. This series contains changes that will cause potential breakage,
> so I suggest to netdev maintainers that it is only applied if there is
> a significant response from testers using the PCS.
>
> Paritcularly, dwmac-qcom-ethqos.c users need to test this, since this
> platform glue driver manipulates the PCS state. Patch 2 is designed to
> print a warning to the kernel log if this glue driver calls
> stmmac_pcs_ctrl_ane() to set the AN state differently to how phylink
> has set it. If this happens, we need to do some pre-work to prevent
> these prints.
>
> .../net/ethernet/stmicro/stmmac/dwmac1000_core.c | 7 +++++-
> drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 7 +++++-
> drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.c | 29 +++++++++++++++++++---
> drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h | 8 +++++-
> 4 files changed, 44 insertions(+), 7 deletions(-)
>
Thank you for the recent stmmac cleanup patches. I apologize for the
late reply. I had limited time to test due to some urgent tasks at work.
This is a long email, please bear with me.
I have the following devices on which I try to test whatever I can (both
of them have the same GMAC core with an integrated PCS, both use
phy-mode="2500base-x"):
- Qualcomm QCS9100 Ride R3 (2xAQR115C PHYs)
- Qualcomm IQ8 EVK (QCA808X PHY) - this is the same board for which I
had posted [1] to resolve its issue with advertising only 2.5G
# Patch Series: net: stmmac: phylink PCS conversion
I tested this series soon after it got merged to net-next, probably when
I tested out the hwif.c cleanups. A summary:
- QCS9100 Ride R3 - no issues found.
- IQ8 EVK - same behavior as without this patch, i.e. 2.5G was working
fine, other speeds aren't advertised.
However, this might have been expected as both boards are using
2500Base-X whereas the integrated PCS changes are limited to SGMII.
*Sidenote*: I was able to get 2.5G and lower speeds to work on the IQ8
EVK after adding an additional case for 2500Base-X on top of your patch.
# Patch Series (current): net: stmmac: phylink PCS conversion part 3
(dodgy stuff)
- QCS9100 Ride R3 - functionality seems to be fine (again, probably
due to the changes only affecting SGMII mode). However, the warning
added in patch 2 comes up whenever there's a speed change (I added
an additional WARN_ON to check the sequence):
[ 61.663685] qcom-ethqos 23000000.ethernet eth0: Link is Down
[ 66.235461] dwmac: PCS configuration changed from phylink by glue, please report: 0x00001000 -> 0x00000000
[ 66.245488] ------------[ cut here ]------------
[ 66.250240] WARNING: CPU: 0 PID: 71 at drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h:130 dwmac4_ctrl_ane+0x68/0x84 [stmmac]
[ 66.369320] CPU: 0 UID: 0 PID: 71 Comm: kworker/u33:2 Tainted: G W 6.18.0-rc2-00357-g6c595c926e8f-dirty #1 PREEMPT
[ 66.381547] Tainted: [W]=WARN
[ 66.384608] Hardware name: Qualcomm Technologies, Inc. Lemans Ride Rev3 (DT)
[ 66.391848] Workqueue: events_power_efficient phylink_resolve
[ 66.397770] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 66.404920] pc : dwmac4_ctrl_ane+0x68/0x84 [stmmac]
[ 66.409949] lr : dwmac4_ctrl_ane+0x68/0x84 [stmmac]
[ 66.414975] sp : ffff80008124bc20
[ 66.418387] x29: ffff80008124bc20 x28: 0000000000000001 x27: 0000000000000000
[ 66.425720] x26: 0000000000000001 x25: 0000000000000001 x24: 0000000008032000
[ 66.433053] x23: ffff0000b1148a00 x22: 0000000008032000 x21: 00000000000009c4
[ 66.440386] x20: ffff8000847300e0 x19: 0000000000000000 x18: 00000000ffffffff
[ 66.447719] x17: 657220657361656c x16: 70202c65756c6720 x15: 7962206b6e696c79
[ 66.455053] x14: 6870206d6f726620 x13: 3030303030303030 x12: ffffc6e220a06cf0
[ 66.462386] x11: 0000000000000486 x10: 0000000000000018 x9 : ffffc6e220a06cf0
[ 66.469718] x8 : 00000000ffffefff x7 : ffffc6e220a5ecf0 x6 : 0000000000000000
[ 66.477051] x5 : ffff000ec7437408 x4 : 0000000000000001 x3 : 0000000000000000
[ 66.484384] x2 : 0000000000000000 x1 : ffff0000812a8000 x0 : 000000000000005e
[ 66.491718] Call trace:
[ 66.494245] dwmac4_ctrl_ane+0x68/0x84 [stmmac] (P)
[ 66.499273] ethqos_configure_sgmii+0x114/0x1c0 [dwmac_qcom_ethqos]
[ 66.505711] ethqos_fix_mac_speed+0x6c/0xec [dwmac_qcom_ethqos]
[ 66.511795] stmmac_mac_link_up+0xd4/0x370 [stmmac]
[ 66.516823] phylink_resolve+0x150/0x604
[ 66.520861] process_one_work+0x148/0x28c
[ 66.524999] worker_thread+0x2d8/0x3d8
[ 66.528855] kthread+0x134/0x208
[ 66.532181] ret_from_fork+0x10/0x20
[ 66.535870] ---[ end trace 0000000000000000 ]---
[ 66.540750] qcom-ethqos 23000000.ethernet eth0: Link is Up - 2.5Gbps/Full - flow control rx/tx
- IQ8 EVK - I will try to test it soon and share the results.
Would it be helpful to change the phy-mode to SGMII for some further testing?
Ayaan
---
[1] https://lore.kernel.org/netdev/20250914-qca808x_rate_match-v1-1-0f9e6a331c3b@oss.qualcomm.com/T/#u
next prev parent reply other threads:[~2025-10-28 21:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-25 20:47 [PATCH net-next 0/3] net: stmmac: phylink PCS conversion part 3 (dodgy stuff) Russell King (Oracle)
2025-10-25 20:48 ` [PATCH net-next 1/3] net: stmmac: configure AN control according to phylink Russell King (Oracle)
2025-10-25 20:48 ` [PATCH net-next 2/3] net: stmmac: report PCS configuration changes Russell King (Oracle)
2025-10-25 20:48 ` [PATCH net-next 3/3] net: stmmac: add support specifying PCS supported interfaces Russell King (Oracle)
2025-10-28 10:16 ` Maxime Chevallier
2025-10-28 10:35 ` Russell King (Oracle)
2025-10-28 10:40 ` Russell King (Oracle)
2025-10-28 11:26 ` Maxime Chevallier
2025-10-28 21:12 ` Mohd Ayaan Anwar [this message]
2025-10-29 9:22 ` [PATCH net-next 0/3] net: stmmac: phylink PCS conversion part 3 (dodgy stuff) Russell King (Oracle)
2025-10-30 13:20 ` Mohd Ayaan Anwar
2025-10-30 15:19 ` Russell King (Oracle)
2025-10-30 15:22 ` Russell King (Oracle)
2025-11-03 8:58 ` Mohd Ayaan Anwar
2025-11-03 9:52 ` Russell King (Oracle)
2025-11-03 10:18 ` Mohd Ayaan Anwar
2025-11-03 10:47 ` Russell King (Oracle)
2025-11-03 10:48 ` Vladimir Oltean
2025-11-03 11:20 ` Mohd Ayaan Anwar
2025-11-03 11:43 ` Russell King (Oracle)
2025-11-03 12:13 ` Vladimir Oltean
2025-11-03 14:47 ` Mohd Ayaan Anwar
2025-11-03 17:15 ` Russell King (Oracle)
2025-11-03 17:02 ` Russell King (Oracle)
2025-11-03 12:17 ` Mohd Ayaan Anwar
2025-11-03 17:13 ` Russell King (Oracle)
2025-11-05 15:46 ` Mohd Ayaan Anwar
2025-11-05 18:12 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQExx0zXT5SvFxAk@oss.qualcomm.com \
--to=mohd.anwar@oss$(echo .)qualcomm.com \
--cc=0x1207@gmail$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=alexis.lothore@bootlin$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andrew@lunn$(echo .)ch \
--cc=boon.khai.ng@altera$(echo .)com \
--cc=daniel.machon@microchip$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eleanor15x@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jan.petrous@oss$(echo .)nxp.com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox