public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Sabrina Dubroca <sd@queasysnail•net>
To: Hangbin Liu <liuhangbin@gmail•com>
Cc: Jay Vosburgh <jv@jvosburgh•net>,
	Andrew Lunn <andrew+netdev@lunn•ch>,
	"David S. Miller" <davem@davemloft•net>,
	Eric Dumazet <edumazet@google•com>,
	Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
	Jiri Pirko <jiri@resnulli•us>,
	Nikolay Aleksandrov <razor@blackwall•org>,
	Ido Schimmel <idosch@nvidia•com>, Simon Horman <horms@kernel•org>,
	Sridhar Samudrala <sridhar.samudrala@intel•com>,
	netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
	bridge@lists•linux.dev
Subject: Re: [PATCH net-next v3 3/5] macsec: move netdev_upper_dev_link() after macsec_changelink_common()
Date: Tue, 17 Mar 2026 12:58:54 +0100	[thread overview]
Message-ID: <ablB_tdLxMPoYtv3@krikkit> (raw)
In-Reply-To: <20260316-offload_compute-v3-3-a5d4a07d86d3@gmail.com>

2026-03-16, 12:26:11 +0800, Hangbin Liu wrote:
> After calling netdev_change_features() in __netdev_upper_dev_link(),
> the call stack looks like:
> 
> - netdev_upper_dev_link
>   - __netdev_upper_dev_link
>     - netdev_change_features
>       - notifier_call_chain
>         - rtnetlink_event
>           - rtmsg_ifinfo_event
>             - rtmsg_ifinfo_build_skb
> 
> In macsec, we call netdev_upper_dev_link() before
> macsec_changelink_common(), which causes the fields of the MACsec
> Security Entity to be uninitialized. Later, macsec_fill_info() returns
> -EMSGSIZE and triggers WARN_ON() in rtmsg_ifinfo_build_skb.
> 
> Fix this by moving netdev_upper_dev_link() after
> macsec_changelink_common(), and return 0 if secy->key_len is not
> initialized yet.
> 
> Suggested-by: Sabrina Dubroca <sd@queasysnail•net>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail•com>
> ---
>  drivers/net/macsec.c | 23 ++++++++++++-----------
>  1 file changed, 12 insertions(+), 11 deletions(-)

I'm not sure I'll manage to look at the rest of the series before it's
applied, but for this patch:

Reviewed-by: Sabrina Dubroca <sd@queasysnail•net>

Thanks Hangbin.

-- 
Sabrina

next prev parent reply	other threads:[~2026-03-17 11:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16  4:26 [PATCH net-next v3 0/5] net: centralize master device offload feature computation Hangbin Liu
2026-03-16  4:26 ` [PATCH net-next v3 1/5] net: add ndo_update_offloads for offload computation Hangbin Liu
2026-03-17 15:14   ` Sabrina Dubroca
2026-03-18  1:15     ` Hangbin Liu
2026-03-18 23:29       ` Sabrina Dubroca
2026-03-19  2:02         ` Hangbin Liu
2026-03-16  4:26 ` [PATCH net-next v3 2/5] net: use ndo_update_offloads to set offload features for bonding/bridge/team Hangbin Liu
2026-03-19  9:16   ` [net-next,v3,2/5] " Paolo Abeni
2026-03-16  4:26 ` [PATCH net-next v3 3/5] macsec: move netdev_upper_dev_link() after macsec_changelink_common() Hangbin Liu
2026-03-17 11:58   ` Sabrina Dubroca [this message]
2026-03-16  4:26 ` [PATCH net-next v3 4/5] failover: use ndo_update_offloads for failover offload compute Hangbin Liu
2026-03-16  4:26 ` [PATCH net-next v3 5/5] net: no need to disable LRO specifically Hangbin Liu
2026-03-19  9:52 ` [PATCH net-next v3 0/5] net: centralize master device offload feature computation Paolo Abeni
2026-03-19 13:37   ` Hangbin Liu
2026-03-19 16:01   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ablB_tdLxMPoYtv3@krikkit \
    --to=sd@queasysnail$(echo .)net \
    --cc=andrew+netdev@lunn$(echo .)ch \
    --cc=bridge@lists$(echo .)linux.dev \
    --cc=davem@davemloft$(echo .)net \
    --cc=edumazet@google$(echo .)com \
    --cc=horms@kernel$(echo .)org \
    --cc=idosch@nvidia$(echo .)com \
    --cc=jiri@resnulli$(echo .)us \
    --cc=jv@jvosburgh$(echo .)net \
    --cc=kuba@kernel$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=liuhangbin@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=razor@blackwall$(echo .)org \
    --cc=sridhar.samudrala@intel$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox