From: Hangbin Liu <liuhangbin@gmail•com>
To: Paolo Abeni <pabeni@redhat•com>
Cc: Jay Vosburgh <jv@jvosburgh•net>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Jiri Pirko <jiri@resnulli•us>,
Nikolay Aleksandrov <razor@blackwall•org>,
Ido Schimmel <idosch@nvidia•com>, Simon Horman <horms@kernel•org>,
Sabrina Dubroca <sd@queasysnail•net>,
Sridhar Samudrala <sridhar.samudrala@intel•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
bridge@lists•linux.dev
Subject: Re: [PATCH net-next v3 0/5] net: centralize master device offload feature computation
Date: Thu, 19 Mar 2026 13:37:17 +0000 [thread overview]
Message-ID: <abv8DXkR0RtnZJ8P@fedora> (raw)
In-Reply-To: <337a938c-8a03-43f8-8402-745020185b37@redhat.com>
On Thu, Mar 19, 2026 at 10:52:34AM +0100, Paolo Abeni wrote:
> I'm sorry for the late feedback, but I think the driver cleanup and
> simplification is not worthy the core complexity and the new NDO added.
>
> The AI reported issue would probably need very non trivial changes to
> both team and bond driver to be addressed.
>
> Most of the cleanups belong to netdev_compute_master_upper_features()
> introduction in the failover driver. Factoring out that single change
> would be IMHO a better option, if possible.
>
> The new ndo looks controversial. We already have 2 different ndo at
> __netdev_update_features() time, with slightly different semantic.
> Adding another one feels like a design issue.
Thanks, I will check if we can call netdev_compute_master_upper_features()
in failover driver directly.
Hangbin
next prev parent reply other threads:[~2026-03-19 13:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 4:26 [PATCH net-next v3 0/5] net: centralize master device offload feature computation Hangbin Liu
2026-03-16 4:26 ` [PATCH net-next v3 1/5] net: add ndo_update_offloads for offload computation Hangbin Liu
2026-03-17 15:14 ` Sabrina Dubroca
2026-03-18 1:15 ` Hangbin Liu
2026-03-18 23:29 ` Sabrina Dubroca
2026-03-19 2:02 ` Hangbin Liu
2026-03-16 4:26 ` [PATCH net-next v3 2/5] net: use ndo_update_offloads to set offload features for bonding/bridge/team Hangbin Liu
2026-03-19 9:16 ` [net-next,v3,2/5] " Paolo Abeni
2026-03-16 4:26 ` [PATCH net-next v3 3/5] macsec: move netdev_upper_dev_link() after macsec_changelink_common() Hangbin Liu
2026-03-17 11:58 ` Sabrina Dubroca
2026-03-16 4:26 ` [PATCH net-next v3 4/5] failover: use ndo_update_offloads for failover offload compute Hangbin Liu
2026-03-16 4:26 ` [PATCH net-next v3 5/5] net: no need to disable LRO specifically Hangbin Liu
2026-03-19 9:52 ` [PATCH net-next v3 0/5] net: centralize master device offload feature computation Paolo Abeni
2026-03-19 13:37 ` Hangbin Liu [this message]
2026-03-19 16:01 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abv8DXkR0RtnZJ8P@fedora \
--to=liuhangbin@gmail$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=bridge@lists$(echo .)linux.dev \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=idosch@nvidia$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=jv@jvosburgh$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=sd@queasysnail$(echo .)net \
--cc=sridhar.samudrala@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox