From: Roland Dreier <rdreier@cisco•com>
To: "Ramachandra K" <ramachandra.kuchimanchi@qlogic•com>
Cc: netdev@vger•kernel.org, poornima.kamath@qlogic•com,
general@lists•openfabrics.org, amar.mudrankit@qlogic•com
Subject: Re: [ofa-general] Re: [PATCH 01/13] QLogic VNIC: Driver - netdev implementation
Date: Mon, 05 May 2008 13:42:15 -0700 [thread overview]
Message-ID: <adafxsw1o0o.fsf@cisco.com> (raw)
In-Reply-To: <71d336490805050836o68d745f2k4bab68edcfe1da50@mail.gmail.com> (Ramachandra K.'s message of "Mon, 5 May 2008 21:06:58 +0530")
> I will make sure to sign off on all patches. Should I also drop the From line
> for the patches which I developed, since I am mailing them myself ?
It doesn't hurt to include a From: line if it is the same as the one for
the email itself, but it isn't necessary. When I import a patch the
last From: line will be used.
> I am using the Signed-off-by line to indicate the people who were
> involved in the development of the patches at some stage.
That's fine. You can read Documentation/SubmittingPatches to see the
precise legal meaning of Signed-off-by, and make sure that it applies to
everyone whose signoff you are including. You can also add less formal
text like "X <z@foo> helped develop this patch" in the changelog entry.
> > > +extern cycles_t recv_ref;
> >
> > seems like too generic a name to make global. What the heck are you
> > using cycle_t to keep track of anyway?
> >
>
> This is being used as part of the driver internal statistics
> collection to keep track of the time
> elapsed between a message arriving from the EVIC indicating that it
> has done an RDMA write of
> an Ethernet packet to the driver memory and the driver giving the packet
> to the network stack.
cycles don't track time (eg x86 TSC might stop for a while). Do you
*really* need to use cycles, or are jiffies a better replacement?
- R.
next prev parent reply other threads:[~2008-05-05 20:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 17:15 [ofa-general] [PATCH 00/13] QLogic Virtual NIC (VNIC) Driver Ramachandra K
2008-04-30 17:16 ` [ofa-general] [PATCH 01/13] QLogic VNIC: Driver - netdev implementation Ramachandra K
2008-05-02 18:15 ` Roland Dreier
2008-05-05 15:36 ` [ofa-general] " Ramachandra K
2008-05-05 20:42 ` Roland Dreier [this message]
2008-04-30 17:16 ` [ofa-general] [PATCH 02/13] QLogic VNIC: Netpath - abstraction of connection to EVIC/VEx Ramachandra K
2008-04-30 17:17 ` [ofa-general] [PATCH 03/13] QLogic VNIC: Implementation of communication protocol with EVIC/VEx Ramachandra K
2008-04-30 17:17 ` [ofa-general] [PATCH 04/13] QLogic VNIC: Implementation of Control path of communication protocol Ramachandra K
2008-04-30 17:18 ` [ofa-general] [PATCH 05/13] QLogic VNIC: Implementation of Data " Ramachandra K
2008-04-30 17:18 ` [ofa-general] [PATCH 06/13] QLogic VNIC: IB core stack interaction Ramachandra K
2008-05-13 20:40 ` [ofa-general] " Roland Dreier
2008-04-30 17:19 ` [ofa-general] [PATCH 07/13] QLogic VNIC: Handling configurable parameters of the driver Ramachandra K
2008-05-13 20:41 ` Roland Dreier
2008-04-30 17:19 ` [ofa-general] [PATCH 08/13] QLogic VNIC: sysfs interface implementation for " Ramachandra K
2008-05-01 14:56 ` Stephen Hemminger
2008-05-01 16:02 ` [ofa-general] " Kuchimanchi, Ramachandra (Contractor - )
2008-05-01 16:43 ` [ofa-general] [RESEND] " Ramachandra K
2008-05-01 18:22 ` [ofa-general] " Stephen Hemminger
2008-04-30 17:20 ` [ofa-general] [PATCH 09/13] QLogic VNIC: IB Multicast for Ethernet broadcast/multicast Ramachandra K
2008-05-15 22:38 ` Roland Dreier
2008-04-30 17:20 ` [ofa-general] [PATCH 10/13] QLogic VNIC: Driver Statistics collection Ramachandra K
2008-05-15 22:33 ` Roland Dreier
2008-05-20 16:52 ` [ofa-general] " Ramachandra K
2008-04-30 17:21 ` [PATCH 11/13] QLogic VNIC: Driver utility file - implements various utility macros Ramachandra K
2008-05-01 14:58 ` [ofa-general] " Stephen Hemminger
2008-05-01 16:18 ` [ofa-general] " Kuchimanchi, Ramachandra (Contractor - )
2008-05-01 17:01 ` Ramachandra K
2008-05-01 18:26 ` Stephen Hemminger
2008-04-30 17:21 ` [ofa-general] [PATCH 12/13] QLogic VNIC: Driver Kconfig and Makefile Ramachandra K
2008-05-15 22:31 ` Roland Dreier
2008-04-30 17:22 ` [ofa-general] [PATCH 13/13] QLogic VNIC: Modifications to IB " Ramachandra K
2008-04-30 22:25 ` [ofa-general] Re: [PATCH 00/13] QLogic Virtual NIC (VNIC) Driver Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adafxsw1o0o.fsf@cisco.com \
--to=rdreier@cisco$(echo .)com \
--cc=amar.mudrankit@qlogic$(echo .)com \
--cc=general@lists$(echo .)openfabrics.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=poornima.kamath@qlogic$(echo .)com \
--cc=ramachandra.kuchimanchi@qlogic$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox