From: Subash Abhinov Kasiviswanathan <subashab@codeaurora•org>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Tom Herbert <tom@herbertland•com>,
davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH net-next 4/4] net: qualcomm: rmnet: Add support for GRO
Date: Wed, 25 Oct 2017 12:00:18 -0600 [thread overview]
Message-ID: <b557f39a42f86307eb580b7c02fe8a0e@codeaurora.org> (raw)
In-Reply-To: <1508940057.30291.122.camel@edumazet-glaptop3.roam.corp.google.com>
> You need to check return code and abort if memory could not be
> allocated.
>
> There is a reason this helper has _init() prefix, it does not belong to
> _setup() since a _setup() is not expected to fail.
>
> Please take a look at other gro_cells_init() callers, and you will
> notice that it is called from ndo_init()
>
> You might have copied the only buggy caller (vxlan).
>
> Tom, if you read me fix vxlan, thanks !
Hi Eric
Thanks for pointing this out. I'll change this in v2.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2017-10-25 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 4:55 [PATCH net-next 0/4] net: qualcomm: rmnet: Add 64 bit stats and GRO Subash Abhinov Kasiviswanathan
2017-10-25 4:55 ` [PATCH net-next 1/4] net: qualcomm: rmnet: Fix the return value of rmnet_rx_handler() Subash Abhinov Kasiviswanathan
2017-10-25 4:55 ` [PATCH net-next 2/4] net: qualcomm: rmnet: Always assign rmnet dev in deaggregation path Subash Abhinov Kasiviswanathan
2017-10-25 4:55 ` [PATCH net-next 3/4] net: qualcomm: rmnet: Add support for 64 bit stats Subash Abhinov Kasiviswanathan
2017-10-25 4:55 ` [PATCH net-next 4/4] net: qualcomm: rmnet: Add support for GRO Subash Abhinov Kasiviswanathan
2017-10-25 14:00 ` Eric Dumazet
2017-10-25 18:00 ` Subash Abhinov Kasiviswanathan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b557f39a42f86307eb580b7c02fe8a0e@codeaurora.org \
--to=subashab@codeaurora$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tom@herbertland$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox