From: Florian Fainelli <f.fainelli@gmail•com>
To: Vladimir Oltean <olteanv@gmail•com>,
andrew@lunn•ch, vivien.didelot@gmail•com, davem@davemloft•net,
jakub.kicinski@netronome•com
Cc: murali.policharla@broadcom•com, stephen@networkplumber•org,
jiri@resnulli•us, idosch@idosch•org, kuba@kernel•org,
nikolay@cumulusnetworks•com, netdev@vger•kernel.org
Subject: Re: [PATCH v3 net-next 5/8] net: dsa: b53: add MTU configuration support
Date: Thu, 26 Mar 2020 16:16:38 -0700 [thread overview]
Message-ID: <ca7e48c2-249a-9066-045f-04708474ef8a@gmail.com> (raw)
In-Reply-To: <20200326224040.32014-6-olteanv@gmail.com>
On 3/26/2020 3:40 PM, Vladimir Oltean wrote:
> From: Murali Krishna Policharla <murali.policharla@broadcom•com>
>
> It looks like the Broadcomm switches supported by the b53 driver don't
^= one too many m's, the attempt to acquire
Qualcomm failed a few years ago :)
> support precise configuration of the MTU, but just a mumbo-jumbo boolean
> flag. Set that.
>
> Also configure BCM583XX devices to send and receive jumbo frames when
> ports are configured with 10/100 Mbps speed.
>
> Signed-off-by: Murali Krishna Policharla <murali.policharla@broadcom•com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp•com>
> ---
[snip]
> +static int b53_change_mtu(struct dsa_switch *ds, int port, int mtu)
> +{
> + struct b53_device *dev = ds->priv;
> + bool enable_jumbo;
> + bool allow_10_100;
> +
> + if (is5325(dev) || is5365(dev))
> + return -EOPNOTSUPP;
> +
> + enable_jumbo = (mtu >= JMS_MIN_SIZE);
> + allow_10_100 = (dev->chip_id == BCM58XX_DEVICE_ID);
I believe this was meant to be BCM583XX_DEVICE_ID to be consistent with
the previous patch version. With that:
Acked-by: Florian Fainelli <f.fainelli@gmail•com>
--
Florian
next prev parent reply other threads:[~2020-03-26 23:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 22:40 [PATCH v3 net-next 0/8] Configure the MTU on DSA switches Vladimir Oltean
2020-03-26 22:40 ` [PATCH v3 net-next 1/8] net: phy: bcm7xx: add jumbo frame configuration to PHY Vladimir Oltean
2020-03-26 23:17 ` Florian Fainelli
2020-03-26 22:40 ` [PATCH v3 net-next 2/8] bgmac: configure MTU and add support for frames beyond 8192 byte size Vladimir Oltean
2020-03-26 22:40 ` [PATCH v3 net-next 3/8] net: dsa: configure the MTU for switch ports Vladimir Oltean
2020-03-27 0:06 ` Andrew Lunn
2020-03-27 10:00 ` Vladimir Oltean
2020-03-26 22:40 ` [PATCH v3 net-next 4/8] net: dsa: implement auto-normalization of MTU for bridge hardware datapath Vladimir Oltean
2020-04-02 1:25 ` kbuild test robot
2020-03-26 22:40 ` [PATCH v3 net-next 5/8] net: dsa: b53: add MTU configuration support Vladimir Oltean
2020-03-26 23:16 ` Florian Fainelli [this message]
2020-03-27 13:01 ` Vladimir Oltean
2020-03-26 22:40 ` [PATCH v3 net-next 6/8] net: dsa: sja1105: implement the port MTU callbacks Vladimir Oltean
2020-03-26 22:40 ` [PATCH v3 net-next 7/8] net: dsa: vsc73xx: make the MTU configurable Vladimir Oltean
2020-03-26 22:40 ` [PATCH v3 net-next 8/8] net: dsa: felix: support changing the MTU Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca7e48c2-249a-9066-045f-04708474ef8a@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=idosch@idosch$(echo .)org \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=murali.policharla@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=olteanv@gmail$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox