From: Daniel Borkmann <daniel@iogearbox•net>
To: davem@davemloft•net
Cc: alexei.starovoitov@gmail•com, bblanco@plumgrid•com,
tariqt@mellanox•com, zhiyisun@gmail•com, ranas@mellanox•com,
netdev@vger•kernel.org, Daniel Borkmann <daniel@iogearbox•net>
Subject: [PATCH net 0/3] Couple of BPF refcount fixes for mlx5
Date: Mon, 14 Nov 2016 01:43:39 +0100 [thread overview]
Message-ID: <cover.1479080215.git.daniel@iogearbox.net> (raw)
Various mlx5 bugs on eBPF program and refcount handling I found during review.
Since these kind of bugs happened multiple times here, I'll add a __must_check
to the bpf_prog_inc()/bpf_prog_add()/etc functions for net-next, so these things
will let the compiler (and thus kbuild bot) bark early enough. Note, turned out,
I had to take the hunk from c540594f864b ("bpf, mlx4: fix prog refcount in
mlx4_en_try_alloc_resources error path") to get bpf_prog_sub() function for net
as well, but the merge into net-next should add no conflicts.
Rana, please review.
Thanks a lot!
Daniel Borkmann (3):
bpf, mlx5: fix mlx5e_create_rq taking reference on prog
bpf, mlx5: fix various refcount/prog issues in mlx5e_xdp_set
bpf, mlx5: drop priv->xdp_prog reference on netdev cleanup
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 42 ++++++++++++++++++-----
include/linux/bpf.h | 5 +++
kernel/bpf/syscall.c | 12 +++++++
3 files changed, 51 insertions(+), 8 deletions(-)
--
1.9.3
next reply other threads:[~2016-11-14 0:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 0:43 Daniel Borkmann [this message]
2016-11-14 0:43 ` [PATCH net 1/3] bpf, mlx5: fix mlx5e_create_rq taking reference on prog Daniel Borkmann
2016-11-14 18:15 ` Saeed Mahameed
2016-11-14 18:26 ` Daniel Borkmann
2016-11-14 0:43 ` [PATCH net 2/3] bpf, mlx5: fix various refcount/prog issues in mlx5e_xdp_set Daniel Borkmann
2016-11-14 2:49 ` Alexei Starovoitov
2016-11-14 8:49 ` Daniel Borkmann
2016-11-14 17:35 ` Alexei Starovoitov
2016-11-14 18:23 ` Daniel Borkmann
2016-11-14 18:27 ` Saeed Mahameed
2016-11-14 19:05 ` Daniel Borkmann
2016-11-14 0:43 ` [PATCH net 3/3] bpf, mlx5: drop priv->xdp_prog reference on netdev cleanup Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1479080215.git.daniel@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=bblanco@plumgrid$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ranas@mellanox$(echo .)com \
--cc=tariqt@mellanox$(echo .)com \
--cc=zhiyisun@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox