* [PATCH net 0/2] net: explicitly requires bash when needed.
@ 2018-10-11 8:54 Paolo Abeni
2018-10-11 8:54 ` [PATCH net 1/2] selftests: rtnetlink.sh explicitly requires bash Paolo Abeni
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Paolo Abeni @ 2018-10-11 8:54 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Florian Westphal, Willem de Bruijn
Some test scripts require bash-only features but use the default shell.
This may cause random failures if the default shell is not bash.
Instead of doing a potentially complex rewrite of such scripts, these patches
require the bash interpreter, where needed.
Paolo Abeni (2):
selftests: rtnetlink.sh explicitly requires bash.
selftests: udpgso_bench.sh explicitly requires bash
tools/testing/selftests/net/rtnetlink.sh | 2 +-
tools/testing/selftests/net/udpgso_bench.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.17.2
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH net 1/2] selftests: rtnetlink.sh explicitly requires bash.
2018-10-11 8:54 [PATCH net 0/2] net: explicitly requires bash when needed Paolo Abeni
@ 2018-10-11 8:54 ` Paolo Abeni
2018-10-11 8:54 ` [PATCH net 2/2] selftests: udpgso_bench.sh " Paolo Abeni
2018-10-11 17:19 ` [PATCH net 0/2] net: explicitly requires bash when needed David Miller
2 siblings, 0 replies; 5+ messages in thread
From: Paolo Abeni @ 2018-10-11 8:54 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Florian Westphal, Willem de Bruijn
the script rtnetlink.sh requires a bash-only features (sleep with sub-second
precision). This may cause random test failure if the default shell is not
bash.
Address the above explicitly requiring bash as the script interpreter.
Fixes: 33b01b7b4f19 ("selftests: add rtnetlink test script")
Signed-off-by: Paolo Abeni <pabeni@redhat•com>
---
tools/testing/selftests/net/rtnetlink.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
index 08c341b49760..e101af52d1d6 100755
--- a/tools/testing/selftests/net/rtnetlink.sh
+++ b/tools/testing/selftests/net/rtnetlink.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
#
# This test is for checking rtnetlink callpaths, and get as much coverage as possible.
#
--
2.17.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH net 2/2] selftests: udpgso_bench.sh explicitly requires bash
2018-10-11 8:54 [PATCH net 0/2] net: explicitly requires bash when needed Paolo Abeni
2018-10-11 8:54 ` [PATCH net 1/2] selftests: rtnetlink.sh explicitly requires bash Paolo Abeni
@ 2018-10-11 8:54 ` Paolo Abeni
2018-10-11 13:48 ` Willem de Bruijn
2018-10-11 17:19 ` [PATCH net 0/2] net: explicitly requires bash when needed David Miller
2 siblings, 1 reply; 5+ messages in thread
From: Paolo Abeni @ 2018-10-11 8:54 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Florian Westphal, Willem de Bruijn
The udpgso_bench.sh script requires several bash-only features. This
may cause random failures if the default shell is not bash.
Address the above explicitly requiring bash as the script interpreter
Fixes: 3a687bef148d ("selftests: udp gso benchmark")
Signed-off-by: Paolo Abeni <pabeni@redhat•com>
---
tools/testing/selftests/net/udpgso_bench.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh
index 850767befa47..99e537ab5ad9 100755
--- a/tools/testing/selftests/net/udpgso_bench.sh
+++ b/tools/testing/selftests/net/udpgso_bench.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
#
# Run a series of udpgso benchmarks
--
2.17.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net 2/2] selftests: udpgso_bench.sh explicitly requires bash
2018-10-11 8:54 ` [PATCH net 2/2] selftests: udpgso_bench.sh " Paolo Abeni
@ 2018-10-11 13:48 ` Willem de Bruijn
0 siblings, 0 replies; 5+ messages in thread
From: Willem de Bruijn @ 2018-10-11 13:48 UTC (permalink / raw)
To: Paolo Abeni
Cc: Network Development, David Miller, Florian Westphal,
Willem de Bruijn
On Thu, Oct 11, 2018 at 4:58 AM Paolo Abeni <pabeni@redhat•com> wrote:
>
> The udpgso_bench.sh script requires several bash-only features. This
> may cause random failures if the default shell is not bash.
> Address the above explicitly requiring bash as the script interpreter
>
> Fixes: 3a687bef148d ("selftests: udp gso benchmark")
> Signed-off-by: Paolo Abeni <pabeni@redhat•com>
Acked-by: Willem de Bruijn <willemb@google•com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net 0/2] net: explicitly requires bash when needed.
2018-10-11 8:54 [PATCH net 0/2] net: explicitly requires bash when needed Paolo Abeni
2018-10-11 8:54 ` [PATCH net 1/2] selftests: rtnetlink.sh explicitly requires bash Paolo Abeni
2018-10-11 8:54 ` [PATCH net 2/2] selftests: udpgso_bench.sh " Paolo Abeni
@ 2018-10-11 17:19 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2018-10-11 17:19 UTC (permalink / raw)
To: pabeni; +Cc: netdev, fw, willemb
From: Paolo Abeni <pabeni@redhat•com>
Date: Thu, 11 Oct 2018 10:54:51 +0200
> Some test scripts require bash-only features but use the default shell.
> This may cause random failures if the default shell is not bash.
> Instead of doing a potentially complex rewrite of such scripts, these patches
> require the bash interpreter, where needed.
Series applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-12 0:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-11 8:54 [PATCH net 0/2] net: explicitly requires bash when needed Paolo Abeni
2018-10-11 8:54 ` [PATCH net 1/2] selftests: rtnetlink.sh explicitly requires bash Paolo Abeni
2018-10-11 8:54 ` [PATCH net 2/2] selftests: udpgso_bench.sh " Paolo Abeni
2018-10-11 13:48 ` Willem de Bruijn
2018-10-11 17:19 ` [PATCH net 0/2] net: explicitly requires bash when needed David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox