From: Andi Kleen <andi@firstfloor•org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
Cc: davem@davemloft•net,
Alexander Duyck <alexander.h.duyck@intel•com>,
netdev@vger•kernel.org, gospo@redhat•com, sassmann@redhat•com
Subject: Re: [net-next 02/11] igb: Use node specific allocations for the q_vectors and rings
Date: Sun, 09 Oct 2011 11:08:47 -0700 [thread overview]
Message-ID: <m21uum2g28.fsf@firstfloor.org> (raw)
In-Reply-To: <1318056461-19562-3-git-send-email-jeffrey.t.kirsher@intel.com> (Jeff Kirsher's message of "Fri, 7 Oct 2011 23:47:32 -0700")
Jeff Kirsher <jeffrey.t.kirsher@intel•com> writes:
>
> for (i = 0; i < adapter->num_tx_queues; i++) {
> - ring = kzalloc(sizeof(struct igb_ring), GFP_KERNEL);
> + if (orig_node == -1) {
> + int cur_node = next_online_node(adapter->node);
> + if (cur_node == MAX_NUMNODES)
> + cur_node = first_online_node;
RR seems quite arbitrary. Who guarantees those nodes have any
relationship with the CPUs submitting on those queues? Or the node
the device is on.
Anyways if it's a good idea probably need to add a
dma_alloc_coherent_node() too
-Andi
--
ak@linux•intel.com -- Speaking for myself only
next prev parent reply other threads:[~2011-10-09 18:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-08 6:47 [net-next 00/11][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-10-08 6:47 ` [net-next 01/11] igb: push data into first igb_tx_buffer sooner to reduce stack usage Jeff Kirsher
2011-10-08 6:47 ` [net-next 02/11] igb: Use node specific allocations for the q_vectors and rings Jeff Kirsher
2011-10-08 19:51 ` David Miller
2011-10-10 16:15 ` Alexander Duyck
2011-10-10 17:50 ` David Miller
2011-10-09 18:08 ` Andi Kleen [this message]
2011-10-10 16:25 ` Alexander Duyck
2011-10-10 16:32 ` Andi Kleen
2011-10-10 17:02 ` Alexander Duyck
2011-10-08 6:47 ` [net-next 03/11] igb: avoid unnecessary conversions from u16 to int Jeff Kirsher
2011-10-08 6:47 ` [net-next 04/11] igb: Consolidate all of the ring feature flags into a single value Jeff Kirsher
2011-10-08 6:47 ` [net-next 05/11] igb: Move ITR related data into work container within the q_vector Jeff Kirsher
2011-10-08 6:47 ` [net-next 06/11] igb: cleanup IVAR configuration Jeff Kirsher
2011-10-08 6:47 ` [net-next 07/11] igb: retire the RX_CSUM flag and use the netdev flag instead Jeff Kirsher
2011-10-08 6:47 ` [net-next 08/11] igb: leave staterr in place and instead us a helper function to check bits Jeff Kirsher
2011-10-08 6:47 ` [net-next 09/11] igb: fix recent VLAN changes that would leave VLANs disabled after reset Jeff Kirsher
2011-10-08 6:47 ` [net-next 10/11] igb: move TX hang check flag into ring->flags Jeff Kirsher
2011-10-08 6:47 ` [net-next 11/11] igb: add support for NETIF_F_RXHASH Jeff Kirsher
2011-10-08 6:52 ` [net-next 00/11][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21uum2g28.fsf@firstfloor.org \
--to=andi@firstfloor$(echo .)org \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sassmann@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox