From: Andi Kleen <andi@firstfloor•org>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: small RPS cache for fragments?
Date: Tue, 17 May 2011 14:44:42 -0700 [thread overview]
Message-ID: <m2aaelypbp.fsf@firstfloor.org> (raw)
In-Reply-To: <1305663288.2691.2.camel@edumazet-laptop> (Eric Dumazet's message of "Tue, 17 May 2011 22:14:48 +0200")
Eric Dumazet <eric.dumazet@gmail•com> writes:
>
> OK but do we have workloads actually needing this optimization at all ?
That's a good a question.
>
> (IP defrag hits a read_lock(&ip4_frags.lock)), so maybe steer all frags
> on a given cpu ?)
Couldn't the lock just be replaced with a hashed or bitmap lock or
bit in low bits of pointer lock?
iirc it just protects the heads of the hash table.
They're not rwlocks, but especially if the locking was more finegrained
that's likely not needed anymore.
-Andi
--
ak@linux•intel.com -- Speaking for myself only
next prev parent reply other threads:[~2011-05-17 21:45 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 18:33 small RPS cache for fragments? David Miller
2011-05-17 20:02 ` Tom Herbert
2011-05-17 20:17 ` Rick Jones
2011-05-17 20:41 ` Rick Jones
2011-05-17 20:49 ` David Miller
2011-05-17 21:00 ` Eric Dumazet
2011-05-17 21:10 ` David Miller
2011-05-17 21:13 ` Rick Jones
2011-05-17 21:13 ` Ben Hutchings
2011-05-17 21:26 ` David Miller
2011-05-17 21:40 ` Rick Jones
2011-05-17 21:27 ` Eric Dumazet
2011-05-17 21:11 ` Rick Jones
2011-05-17 21:11 ` Ben Hutchings
2011-05-17 21:27 ` Tom Herbert
2011-05-17 21:28 ` David Miller
2011-05-17 23:59 ` Changli Gao
2011-05-18 6:37 ` David Miller
2011-05-17 20:14 ` Eric Dumazet
2011-05-17 20:47 ` David Miller
2011-05-17 21:44 ` Andi Kleen [this message]
2011-05-17 21:52 ` Eric Dumazet
2011-05-17 22:03 ` Andi Kleen
2011-05-17 21:44 ` David Miller
2011-05-17 21:48 ` Andi Kleen
2011-05-17 21:50 ` David Miller
2011-05-17 22:06 ` Andi Kleen
2011-05-17 22:42 ` Rick Jones
2011-05-24 20:01 ` David Miller
2011-05-24 21:38 ` Rick Jones
2011-06-04 20:29 ` David Miller
2011-06-06 17:08 ` Rick Jones
2011-06-06 17:15 ` Eric Dumazet
2011-06-06 18:06 ` Rick Jones
2011-06-06 19:23 ` David Miller
2011-06-06 19:22 ` David Miller
2011-06-06 20:05 ` Rick Jones
2011-06-06 21:06 ` Jay Vosburgh
2011-06-06 21:40 ` David Miller
2011-06-06 22:49 ` Chris Friesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2aaelypbp.fsf@firstfloor.org \
--to=andi@firstfloor$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox