public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Christian Hopps <chopps@chopps•org>
To: Jeff Johnson <quic_jjohnson@quicinc•com>
Cc: Christian Hopps <chopps@chopps•org>,
	devel@linux-ipsec•org,
	Steffen Klassert <steffen.klassert@secunet•com>,
	netdev@vger•kernel.org, Christian Hopps <chopps@labn•net>
Subject: Re: [PATCH ipsec-next v4 08/18] xfrm: iptfs: add new iptfs xfrm mode impl
Date: Wed, 26 Jun 2024 10:52:33 -0400	[thread overview]
Message-ID: <m2frszah8k.fsf@ja.int.chopps.org> (raw)
In-Reply-To: <2fa05695-faf9-45ce-95de-f49a6749b828@quicinc.com>

[-- Attachment #1: Type: text/plain, Size: 1804 bytes --]


Jeff Johnson <quic_jjohnson@quicinc•com> writes:

> On 6/17/24 13:53, Christian Hopps wrote:
>> From: Christian Hopps <chopps@labn•net>
>> Add a new xfrm mode implementing AggFrag/IP-TFS from RFC9347.
>> This utilizes the new xfrm_mode_cbs to implement demand-driven IP-TFS
>> functionality. This functionality can be used to increase bandwidth
>> utilization through small packet aggregation, as well as help solve PMTU
>> issues through it's efficient use of fragmentation.
>>    Link: https://www.rfc-editor.org/rfc/rfc9347.txt
>> Multiple commits follow to build the functionality into xfrm_iptfs.c
>> Signed-off-by: Christian Hopps <chopps@labn•net>
>> ---
>>   net/xfrm/Makefile     |   1 +
>>   net/xfrm/xfrm_iptfs.c | 225 ++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 226 insertions(+)
>>   create mode 100644 net/xfrm/xfrm_iptfs.c
>> diff --git a/net/xfrm/Makefile b/net/xfrm/Makefile
>> index 547cec77ba03..cd6520d4d777 100644
>> --- a/net/xfrm/Makefile
>> +++ b/net/xfrm/Makefile
>> @@ -20,5 +20,6 @@ obj-$(CONFIG_XFRM_USER) += xfrm_user.o
>>   obj-$(CONFIG_XFRM_USER_COMPAT) += xfrm_compat.o
>>   obj-$(CONFIG_XFRM_IPCOMP) += xfrm_ipcomp.o
>>   obj-$(CONFIG_XFRM_INTERFACE) += xfrm_interface.o
>> +obj-$(CONFIG_XFRM_IPTFS) += xfrm_iptfs.o
>>   obj-$(CONFIG_XFRM_ESPINTCP) += espintcp.o
>>   obj-$(CONFIG_DEBUG_INFO_BTF) += xfrm_state_bpf.o
>> diff --git a/net/xfrm/xfrm_iptfs.c b/net/xfrm/xfrm_iptfs.c
>> new file mode 100644
>> index 000000000000..e7b5546e1f6a
>> --- /dev/null
>> +++ b/net/xfrm/xfrm_iptfs.c
>> @@ -0,0 +1,225 @@
>> +// SPDX-License-Identifier: GPL-2.0
> ...
>
>> +module_init(xfrm_iptfs_init);
>> +module_exit(xfrm_iptfs_fini);
>> +MODULE_LICENSE("GPL");
>
> missing MODULE_DESCRIPTION() which will cause a warning with make W=1

Added.

Thanks,
Chris.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

  reply	other threads:[~2024-06-26 14:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17 20:52 [PATCH ipsec-next v4 00/18] Add IP-TFS mode to xfrm Christian Hopps
2024-06-17 20:52 ` [PATCH ipsec-next v4 01/18] xfrm: config: add CONFIG_XFRM_IPTFS Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 02/18] include: uapi: add ip_tfs_*_hdr packet formats Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 03/18] include: uapi: add IPPROTO_AGGFRAG for AGGFRAG in ESP Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 04/18] xfrm: sysctl: allow configuration of global default values Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 05/18] xfrm: netlink: add config (netlink) options Christian Hopps
2024-06-24 15:29   ` Antony Antony
2024-06-26 13:38     ` [devel-ipsec] " Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 06/18] xfrm: add mode_cbs module functionality Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 07/18] xfrm: add generic iptfs defines and functionality Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 08/18] xfrm: iptfs: add new iptfs xfrm mode impl Christian Hopps
2024-06-19 18:22   ` Jeff Johnson
2024-06-26 14:52     ` Christian Hopps [this message]
2024-06-17 20:53 ` [PATCH ipsec-next v4 09/18] xfrm: iptfs: add user packet (tunnel ingress) handling Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 10/18] xfrm: iptfs: share page fragments of inner packets Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 11/18] xfrm: iptfs: add fragmenting of larger than MTU user packets Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 12/18] xfrm: iptfs: add basic receive packet (tunnel egress) handling Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 13/18] xfrm: iptfs: handle received fragmented inner packets Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 14/18] xfrm: iptfs: add reusing received skb for the tunnel egress packet Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 15/18] xfrm: iptfs: add skb-fragment sharing code Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 16/18] xfrm: iptfs: handle reordering of received packets Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 17/18] xfrm: iptfs: only send the NL attrs that corr. to the SA dir Christian Hopps
2024-06-24 15:27   ` [devel-ipsec] " Antony Antony
2024-06-24 15:46     ` Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 18/18] xfrm: iptfs: add tracepoint functionality Christian Hopps
2024-06-18 18:17 ` [PATCH ipsec-next v4 00/18] Add IP-TFS mode to xfrm Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2frszah8k.fsf@ja.int.chopps.org \
    --to=chopps@chopps$(echo .)org \
    --cc=chopps@labn$(echo .)net \
    --cc=devel@linux-ipsec$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=quic_jjohnson@quicinc$(echo .)com \
    --cc=steffen.klassert@secunet$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox