From: Christian Hopps <chopps@chopps•org>
To: Antony Antony <antony@phenome•org>
Cc: Christian Hopps <chopps@chopps•org>,
Steffen Klassert <steffen.klassert@secunet•com>,
netdev@vger•kernel.org, Christian Hopps <chopps@labn•net>,
devel@linux-ipsec•org
Subject: Re: [devel-ipsec] [PATCH ipsec-next v4 05/18] xfrm: netlink: add config (netlink) options
Date: Wed, 26 Jun 2024 09:38:57 -0400 [thread overview]
Message-ID: <m2jzibakia.fsf@ja.int.chopps.org> (raw)
In-Reply-To: <ZnmQ2k9qUyOyBWap@Antony2201.local>
[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]
Antony Antony via Devel <devel@linux-ipsec•org> writes:
> On Mon, Jun 17, 2024 at 04:53:03PM -0400, Christian Hopps via Devel wrote:
>> From: Christian Hopps <chopps@labn•net>
>>
>> Add netlink options for configuring IP-TFS SAs.
>>
>> Signed-off-by: Christian Hopps <chopps@labn•net>
>> ---
>> include/uapi/linux/xfrm.h | 9 ++++++-
>> net/xfrm/xfrm_compat.c | 10 ++++++--
>> net/xfrm/xfrm_user.c | 52 +++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 68 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/uapi/linux/xfrm.h b/include/uapi/linux/xfrm.h
>> index 18ceaba8486e..3bd1f810e079 100644
>> --- a/include/uapi/linux/xfrm.h
>> +++ b/include/uapi/linux/xfrm.h
>> @@ -158,7 +158,8 @@ enum {
>> #define XFRM_MODE_ROUTEOPTIMIZATION 2
>> #define XFRM_MODE_IN_TRIGGER 3
>> #define XFRM_MODE_BEET 4
>> -#define XFRM_MODE_MAX 5
>> +#define XFRM_MODE_IPTFS 5
>> +#define XFRM_MODE_MAX 6
>>
>> /* Netlink configuration messages. */
>> enum {
>> @@ -321,6 +322,12 @@ enum xfrm_attr_type_t {
>> XFRMA_IF_ID, /* __u32 */
>> XFRMA_MTIMER_THRESH, /* __u32 in seconds for input SA */
>> XFRMA_SA_DIR, /* __u8 */
>> + XFRMA_IPTFS_DROP_TIME, /* __u32 in: usec to wait for next seq */
>> + XFRMA_IPTFS_REORDER_WINDOW, /* __u16 in: reorder window size */
>> + XFRMA_IPTFS_DONT_FRAG, /* out: don't use fragmentation */
>> + XFRMA_IPTFS_INIT_DELAY, /* __u32 out: initial packet wait delay (usec) */
>> + XFRMA_IPTFS_MAX_QSIZE, /* __u32 out: max ingress queue size */
>
> + XFRMA_IPTFS_MAX_QSIZE, /* __u32 out: max ingress queue size octets */
>
> Add the units in comments? This would help the users. The "struct
> xfrm_iptfs_config {" mentions it is octets. Adding it to uapi would help the
> users more. The defaults are not so obvious to find.
Will add "octets" to comment (and "pkts" to reorder window comment).
Thanks,
Chris.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2024-06-26 13:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 20:52 [PATCH ipsec-next v4 00/18] Add IP-TFS mode to xfrm Christian Hopps
2024-06-17 20:52 ` [PATCH ipsec-next v4 01/18] xfrm: config: add CONFIG_XFRM_IPTFS Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 02/18] include: uapi: add ip_tfs_*_hdr packet formats Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 03/18] include: uapi: add IPPROTO_AGGFRAG for AGGFRAG in ESP Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 04/18] xfrm: sysctl: allow configuration of global default values Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 05/18] xfrm: netlink: add config (netlink) options Christian Hopps
2024-06-24 15:29 ` Antony Antony
2024-06-26 13:38 ` Christian Hopps [this message]
2024-06-17 20:53 ` [PATCH ipsec-next v4 06/18] xfrm: add mode_cbs module functionality Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 07/18] xfrm: add generic iptfs defines and functionality Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 08/18] xfrm: iptfs: add new iptfs xfrm mode impl Christian Hopps
2024-06-19 18:22 ` Jeff Johnson
2024-06-26 14:52 ` Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 09/18] xfrm: iptfs: add user packet (tunnel ingress) handling Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 10/18] xfrm: iptfs: share page fragments of inner packets Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 11/18] xfrm: iptfs: add fragmenting of larger than MTU user packets Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 12/18] xfrm: iptfs: add basic receive packet (tunnel egress) handling Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 13/18] xfrm: iptfs: handle received fragmented inner packets Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 14/18] xfrm: iptfs: add reusing received skb for the tunnel egress packet Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 15/18] xfrm: iptfs: add skb-fragment sharing code Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 16/18] xfrm: iptfs: handle reordering of received packets Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 17/18] xfrm: iptfs: only send the NL attrs that corr. to the SA dir Christian Hopps
2024-06-24 15:27 ` [devel-ipsec] " Antony Antony
2024-06-24 15:46 ` Christian Hopps
2024-06-17 20:53 ` [PATCH ipsec-next v4 18/18] xfrm: iptfs: add tracepoint functionality Christian Hopps
2024-06-18 18:17 ` [PATCH ipsec-next v4 00/18] Add IP-TFS mode to xfrm Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2jzibakia.fsf@ja.int.chopps.org \
--to=chopps@chopps$(echo .)org \
--cc=antony@phenome$(echo .)org \
--cc=chopps@labn$(echo .)net \
--cc=devel@linux-ipsec$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steffen.klassert@secunet$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox