* [PATCH 1/1] net-gre: clear skb->queue_mapping in GRE recv path
@ 2010-09-24 23:15 chavey
0 siblings, 0 replies; 3+ messages in thread
From: chavey @ 2010-09-24 23:15 UTC (permalink / raw)
To: chavey; +Cc: netdev, therbert
From: chavey <chavey@google•com>
Date: Fri, 24 Sep 2010 15:05:02 -0700
A continuous stream of errors:
slbgre0 received packet on queue [123], but number of RX queues is 1
net_ratelimit: 155786 callbacks suppressed
is filling up /var/log/messages.
This is due to not unsetting skb->queue_mapping in the GRE receive path.
Signed-off-by: chavey <chavey@google•com>
---
net/ipv4/ip_gre.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index 945b20a..53bdb97 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -641,6 +641,7 @@ static int ipgre_rcv(struct sk_buff *skb)
}
skb_tunnel_rx(skb, tunnel->dev);
+ skb_set_queue_mapping(skb, 0);
skb_reset_network_header(skb);
ipgre_ecn_decapsulate(iph, skb);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/1] net-gre: clear skb->queue_mapping in GRE recv path
@ 2010-09-24 23:18 chavey
2010-09-25 6:46 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: chavey @ 2010-09-24 23:18 UTC (permalink / raw)
To: davem; +Cc: netdev
From: chavey <chavey@google•com>
Date: Fri, 24 Sep 2010 15:05:02 -0700
A continuous stream of errors:
slbgre0 received packet on queue [123], but number of RX queues is 1
net_ratelimit: 155786 callbacks suppressed
is filling up /var/log/messages.
This is due to not unsetting skb->queue_mapping in the GRE receive path.
Signed-off-by: chavey <chavey@google•com>
---
net/ipv4/ip_gre.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index 945b20a..53bdb97 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -641,6 +641,7 @@ static int ipgre_rcv(struct sk_buff *skb)
}
skb_tunnel_rx(skb, tunnel->dev);
+ skb_set_queue_mapping(skb, 0);
skb_reset_network_header(skb);
ipgre_ecn_decapsulate(iph, skb);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net-gre: clear skb->queue_mapping in GRE recv path
2010-09-24 23:18 chavey
@ 2010-09-25 6:46 ` Eric Dumazet
0 siblings, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2010-09-25 6:46 UTC (permalink / raw)
To: chavey; +Cc: davem, netdev, Tom Herbert
Le vendredi 24 septembre 2010 à 16:18 -0700, chavey@google•com a écrit :
> From: chavey <chavey@google•com>
> Date: Fri, 24 Sep 2010 15:05:02 -0700
>
> A continuous stream of errors:
>
> slbgre0 received packet on queue [123], but number of RX queues is 1
> net_ratelimit: 155786 callbacks suppressed
>
> is filling up /var/log/messages.
>
> This is due to not unsetting skb->queue_mapping in the GRE receive path.
>
> Signed-off-by: chavey <chavey@google•com>
> ---
> net/ipv4/ip_gre.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
> index 945b20a..53bdb97 100644
> --- a/net/ipv4/ip_gre.c
> +++ b/net/ipv4/ip_gre.c
> @@ -641,6 +641,7 @@ static int ipgre_rcv(struct sk_buff *skb)
> }
>
> skb_tunnel_rx(skb, tunnel->dev);
> + skb_set_queue_mapping(skb, 0);
>
> skb_reset_network_header(skb);
> ipgre_ecn_decapsulate(iph, skb);
Laurent
Please use you full name in your signature,
Then, have you seen Tom Herbert patch yesterday ?
http://patchwork.ozlabs.org/patch/65583/
He suggested to place this skb_set_queue_mapping(skb, 0) inside
skb_tunnel_rx(), so that we dont patch every tunnel driver ...
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-25 6:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-24 23:15 [PATCH 1/1] net-gre: clear skb->queue_mapping in GRE recv path chavey
-- strict thread matches above, loose matches on Subject: below --
2010-09-24 23:18 chavey
2010-09-25 6:46 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox