From: Marco Roeland <marco.roeland@xs4all•nl>
To: Junio C Hamano <junkio@cox•net>
Cc: Marco Roeland <marco.roeland@xs4all•nl>, git@vger•kernel.org
Subject: Re: [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.pm
Date: Wed, 28 Jun 2006 21:21:45 +0200 [thread overview]
Message-ID: <20060628192145.GD5713@fiberbit.xs4all.nl> (raw)
In-Reply-To: <7virml14za.fsf@assigned-by-dhcp.cox.net>
On Wednesday June 28th 2006 Junio C Hamano wrote:
> >> ifeq ($(uname_S),Linux)
> >> NO_STRLCPY = YesPlease
> >> + ifneq (,$(findstring x86_64,$(uname_M)))
> >> + USE_PIC = YesPlease
> >> + endif
> >> endif
>
> In other words, I am wondering why you did not do this more
> obvious one:
>
> ifeq ($(uname_M),x86_64)
> USE_PIC = YesPlease
> endif
>
> My suspicion is that you protected that in Linux on purpose
> because you know that my version would break for somebody else,
> or because you are trying to be cautious not to break other
> platforms you do not have access to, and I cannot tell which.
Sorry for the confusion. Yes that construct is much more readable. I
copy and pasted it from another section in the Makefile and adapted it
to this use. I tested it and it worked so I decided no to change it
anymore. So that clears up the syntactical issue.
I certainly do not know cases outside Linux where this might break on
x86-64. I just tried to limit it to the case I could test. But perhaps
someone with an x86-64 BSD or Solaris might try it?
To paraphrase Dave Jones: I type 'make', it fails. Some 'git log' later
I realise I have to manually define 'USE_PIC'. Hey, why doesn't it work
automagically? Some 'git grep' and I spot a construct for specific
(sub)platforms. Monkey see, monkey do. I type 'make', it works and
monkey sends patch! Thats it! No subtleties involved;-)
--
Marco Roeland
next prev parent reply other threads:[~2006-06-28 19:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 18:35 [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.pm Marco Roeland
2006-06-28 18:53 ` Junio C Hamano
2006-06-28 18:59 ` Junio C Hamano
2006-06-28 19:21 ` Marco Roeland [this message]
2006-06-28 19:55 ` [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.xs Marco Roeland
2006-06-28 20:52 ` [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.pm Pavel Roskin
2006-06-29 22:22 ` Jakub Narebski
2006-06-30 0:03 ` Pavel Roskin
2006-06-30 0:29 ` Jakub Narebski
2006-06-28 19:08 ` Marco Roeland
2006-06-28 21:24 ` Junio C Hamano
2006-06-29 9:04 ` Sergey Vlasov
2006-06-29 9:58 ` Josef Weidendorfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060628192145.GD5713@fiberbit.xs4all.nl \
--to=marco.roeland@xs4all$(echo .)nl \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox