From: Junio C Hamano <junkio@cox•net>
To: Marco Roeland <marco.roeland@xs4all•nl>
Cc: git@vger•kernel.org, pasky@suse•cz
Subject: Re: [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.pm
Date: Wed, 28 Jun 2006 14:24:37 -0700 [thread overview]
Message-ID: <7vbqsdynvu.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060628190814.GC5713@fiberbit.xs4all.nl> (Marco Roeland's message of "Wed, 28 Jun 2006 21:08:14 +0200")
Marco Roeland <marco.roeland@xs4all•nl> writes:
> Even for Linux someone mentioned that probably i386 is the exception in
> _not_ needing the -fPIC linkage. It might even be specific to the Perl
> "xs" implementation specifics?
USE_PIC is for pleasing Perly git and nothing else right now.
> So I should have added "Works for me (TM)"! ;-)
That would have been more explicit way to tell me that this is a
partial solution and I should solicit help from people on other
platforms.
By the way, I had an impression that compiling things with -fPIC
when not necessary was generally a bad idea from performance
point of view. If that is the case we might want to compile,
under USE_PIC, everything with -fPIC in a separate area to
compile and link with Git.xs, without affecting the C-only core
code.
I suspect this would largely depend on the architecture. I ran
git-fsck-objects compiled with and without -fPIC (after "make
clean" to rebuild everything) on a fully packed copy of the
linux-2.6 repository on my x86_64 box, and did not see
meaningful differences:
: gitster; /usr/bin/time ../git.junio/git-fsck-objects-no-pic --full
109.71user 5.01system 1:54.89elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (14major+1834967minor)pagefaults 0swaps
: gitster; /usr/bin/time ../git.junio/git-fsck-objects-with-pic --full
109.05user 4.97system 1:54.08elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (0major+1834981minor)pagefaults 0swaps
: gitster;
next prev parent reply other threads:[~2006-06-28 21:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 18:35 [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.pm Marco Roeland
2006-06-28 18:53 ` Junio C Hamano
2006-06-28 18:59 ` Junio C Hamano
2006-06-28 19:21 ` Marco Roeland
2006-06-28 19:55 ` [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.xs Marco Roeland
2006-06-28 20:52 ` [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.pm Pavel Roskin
2006-06-29 22:22 ` Jakub Narebski
2006-06-30 0:03 ` Pavel Roskin
2006-06-30 0:29 ` Jakub Narebski
2006-06-28 19:08 ` Marco Roeland
2006-06-28 21:24 ` Junio C Hamano [this message]
2006-06-29 9:04 ` Sergey Vlasov
2006-06-29 9:58 ` Josef Weidendorfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbqsdynvu.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=marco.roeland@xs4all$(echo .)nl \
--cc=pasky@suse$(echo .)cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox