From: Junio C Hamano <junkio@cox•net>
To: Marco Roeland <marco.roeland@xs4all•nl>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.pm
Date: Wed, 28 Jun 2006 11:53:00 -0700 [thread overview]
Message-ID: <7vr719159v.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060628183557.GA5713@fiberbit.xs4all.nl> (Marco Roeland's message of "Wed, 28 Jun 2006 20:35:57 +0200")
Marco Roeland <marco.roeland@xs4all•nl> writes:
> In commit 6294a10 it was noted that "on x86-64 it seems that Git.xs does
> not link without compiling the main git objects with -fPIC". Set it
> therefore automatically on this platform.
I agree with it in principle but was too lazy to do that myself.
I wonder it should be inside Linux, though.
> ifeq ($(uname_S),Linux)
> NO_STRLCPY = YesPlease
> + ifneq (,$(findstring x86_64,$(uname_M)))
> + USE_PIC = YesPlease
> + endif
> endif
next prev parent reply other threads:[~2006-06-28 18:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 18:35 [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.pm Marco Roeland
2006-06-28 18:53 ` Junio C Hamano [this message]
2006-06-28 18:59 ` Junio C Hamano
2006-06-28 19:21 ` Marco Roeland
2006-06-28 19:55 ` [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.xs Marco Roeland
2006-06-28 20:52 ` [PATCH] Makefile: set USE_PIC on Linux x86_64 for linking with Git.pm Pavel Roskin
2006-06-29 22:22 ` Jakub Narebski
2006-06-30 0:03 ` Pavel Roskin
2006-06-30 0:29 ` Jakub Narebski
2006-06-28 19:08 ` Marco Roeland
2006-06-28 21:24 ` Junio C Hamano
2006-06-29 9:04 ` Sergey Vlasov
2006-06-29 9:58 ` Josef Weidendorfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr719159v.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=marco.roeland@xs4all$(echo .)nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox