From: Charles Bailey <charles@hashpling•org>
To: Jakub Narebski <jnareb@gmail•com>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH] gitweb: add a setting to control the tabstop width
Date: Mon, 3 Mar 2008 22:52:00 +0000 [thread overview]
Message-ID: <20080303225200.GA8145@hashpling.org> (raw)
In-Reply-To: <200803032333.29426.jnareb@gmail.com>
On Mon, Mar 03, 2008 at 11:33:28PM +0100, Jakub Narebski wrote:
> Charles Bailey <charles@hashpling•org> writes:
> >
> > The untabify function seems the sensible place to make the change. As
> > untabify is called once per line from various different locations it
> > also makes sense to cache the result of the config lookup in a package
> > variable, though this makes the change slightly less neat.
>
> Since b201927 (gitweb: Read repo config using 'git config -z -l')
> repository config is cached in %config hash (per repository), so
> I don't think global / package variable $tabstop_width is really
> needed...
Fair point, although we still save the cost of some 'is the config
variable overrideable and if so is it overriden' logic. Untabify is a
once per line call which is more frequesnt than most gitweb config
checking calls.
> > This change should have a minimal impact on performance but it would
> > appreciate some more eyes and ideally some performance testing on
> > heavier systems than my own.
>
> ...but it would be better if you have checked at least on your system
> if it does affect performance or not.
>
Not noticeably (on an old AMD Duron 900MHz), but my tests have been
unscientific.
> [...]
>
> +our $tabstop_width;
>
> I think I would write "our $tabstop_width = 8;" here.
Currently, I use the fact that it is initially 'undef' to know that I
haven't checked the config yet. The config is then checked on the
first time through untabify.
Charles.
next prev parent reply other threads:[~2008-03-03 22:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 22:11 [PATCH] gitweb: add a setting to control the tabstop width Charles Bailey
2008-03-03 22:33 ` Jakub Narebski
2008-03-03 22:52 ` Charles Bailey [this message]
2008-03-04 0:08 ` Jakub Narebski
2008-03-03 22:52 ` Jakub Narebski
2008-03-03 23:13 ` Junio C Hamano
2008-03-04 3:35 ` Martin Langhoff
2008-03-04 8:19 ` Jakub Narebski
2008-03-04 8:41 ` Charles Bailey
2008-03-04 8:36 ` Charles Bailey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303225200.GA8145@hashpling.org \
--to=charles@hashpling$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jnareb@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox