From: Charles Bailey <charles@hashpling•org>
To: Jakub Narebski <jnareb@gmail•com>
Cc: Martin Langhoff <martin.langhoff@gmail•com>,
Junio C Hamano <gitster@pobox•com>,
git@vger•kernel.org
Subject: Re: [PATCH] gitweb: add a setting to control the tabstop width
Date: Tue, 4 Mar 2008 08:41:20 +0000 [thread overview]
Message-ID: <20080304084120.GB13585@hashpling.org> (raw)
In-Reply-To: <200803040919.44925.jnareb@gmail.com>
On Tue, Mar 04, 2008 at 09:19:43AM +0100, Jakub Narebski wrote:
> On Tue, 4 Mar 2008, Martin Langhoff wrote:
> > On Tue, Mar 4, 2008 at 12:13 PM, Junio C Hamano <gitster@pobox•com> wrote:
> >> Some people say "Tabs are 8 characters, and thus indentations are also 8
> >> characters. There are heretic movements that try to make indentations 4
> >> (or even 2!) characters deep, and that is akin to trying to define the
> >> value of PI to be 3." Some people disagree.
> >
> > And on the web, people use CSS to sort these disagreements amicably...
> > As a web apps guy, adding a setting for something like this, and then
> > changing the output feels _very_ weird, as it breaks with a lot of
> > stuff that Just Works in the HTTP+HTML world even for users that view
> > it differently... like caching :-)
>
> The problem with using CSS to select tabstop width is twofold. First,
> it has to work correctly also in text browsers like lynx, elinks, w3m.
> Second, it is tabstop size, not the width of tab character; I'm not
> sure if it is possible to implement it in CSS.
I do understand Martin's point, it does feel a little wrong performing
a styling action in the html generation but, as Jakub says, I don't
believe there is a good CSS solution to the problem.
My patch doesn't change this issue (expanding tabs in the html
generation), it just makes it a little more flexible.
next prev parent reply other threads:[~2008-03-04 8:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 22:11 [PATCH] gitweb: add a setting to control the tabstop width Charles Bailey
2008-03-03 22:33 ` Jakub Narebski
2008-03-03 22:52 ` Charles Bailey
2008-03-04 0:08 ` Jakub Narebski
2008-03-03 22:52 ` Jakub Narebski
2008-03-03 23:13 ` Junio C Hamano
2008-03-04 3:35 ` Martin Langhoff
2008-03-04 8:19 ` Jakub Narebski
2008-03-04 8:41 ` Charles Bailey [this message]
2008-03-04 8:36 ` Charles Bailey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080304084120.GB13585@hashpling.org \
--to=charles@hashpling$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jnareb@gmail$(echo .)com \
--cc=martin.langhoff@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox