From: Jakub Narebski <jnareb@gmail•com>
To: Charles Bailey <charles@hashpling•org>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH] gitweb: add a setting to control the tabstop width
Date: Mon, 3 Mar 2008 23:52:48 +0100 [thread overview]
Message-ID: <200803032352.48614.jnareb@gmail.com> (raw)
In-Reply-To: <200803032333.29426.jnareb@gmail.com>
Jakub Narebski wrote:
> +our $tabstop_width;
>
> I think I would write "our $tabstop_width = 8;" here.
I'm sorry. Please drop this part. Seting it to undef is needed
if it is used as cache (as: not read in), while if we use %config
it is simply not needed.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2008-03-03 22:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 22:11 [PATCH] gitweb: add a setting to control the tabstop width Charles Bailey
2008-03-03 22:33 ` Jakub Narebski
2008-03-03 22:52 ` Charles Bailey
2008-03-04 0:08 ` Jakub Narebski
2008-03-03 22:52 ` Jakub Narebski [this message]
2008-03-03 23:13 ` Junio C Hamano
2008-03-04 3:35 ` Martin Langhoff
2008-03-04 8:19 ` Jakub Narebski
2008-03-04 8:41 ` Charles Bailey
2008-03-04 8:36 ` Charles Bailey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803032352.48614.jnareb@gmail.com \
--to=jnareb@gmail$(echo .)com \
--cc=charles@hashpling$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox