* [PATCH] date.c: phrase a comment gender neutral
@ 2014-11-18 19:24 Stefan Beller
2014-11-18 19:42 ` Jonathan Nieder
2014-11-18 20:03 ` Junio C Hamano
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Beller @ 2014-11-18 19:24 UTC (permalink / raw)
To: gitster, git; +Cc: Stefan Beller
When looking for suitable functions to print dates,
I found this gem. Let's make it gender neutral as
nowadays people get upset by this gender debate.
Signed-off-by: Stefan Beller <sbeller@google•com>
---
date.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/date.c b/date.c
index 59dfe57..19fb439 100644
--- a/date.c
+++ b/date.c
@@ -732,7 +732,7 @@ int parse_expiry_date(const char *date, unsigned long *timestamp)
/*
* We take over "now" here, which usually translates
* to the current timestamp. This is because the user
- * really means to expire everything she has done in
+ * really means to expire everything they have done in
* the past, and by definition reflogs are the record
* of the past, and there is nothing from the future
* to be kept.
--
2.2.0.rc2.5.gf7b9fb2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] date.c: phrase a comment gender neutral
2014-11-18 19:24 [PATCH] date.c: phrase a comment gender neutral Stefan Beller
@ 2014-11-18 19:42 ` Jonathan Nieder
2014-11-18 20:03 ` Junio C Hamano
1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Nieder @ 2014-11-18 19:42 UTC (permalink / raw)
To: Stefan Beller; +Cc: gitster, git
Stefan Beller wrote:
> When looking for suitable functions to print dates,
> I found this gem. Let's make it gender neutral as
> nowadays people get upset by this gender debate.
Eh, I'm not upset.
Hope that helps,
Jonathan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] date.c: phrase a comment gender neutral
2014-11-18 19:24 [PATCH] date.c: phrase a comment gender neutral Stefan Beller
2014-11-18 19:42 ` Jonathan Nieder
@ 2014-11-18 20:03 ` Junio C Hamano
2014-11-18 20:07 ` Stefan Beller
1 sibling, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2014-11-18 20:03 UTC (permalink / raw)
To: Stefan Beller; +Cc: git
Stefan Beller <sbeller@google•com> writes:
> When looking for suitable functions to print dates,
> I found this gem. Let's make it gender neutral as
> nowadays people get upset by this gender debate.
For some time I used to use "she/her" on Mondays, Wednesdays and
Fridays and "he/his" on other days to balance them, and you are
seeing the artifact of that.
Some people might feel that we would be better off using "they" all
the time, but IMO it's such a minor thing that once it _is_ in the
tree, it's not really worth the patch noise to go and fix it up.
>
> Signed-off-by: Stefan Beller <sbeller@google•com>
> ---
> date.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/date.c b/date.c
> index 59dfe57..19fb439 100644
> --- a/date.c
> +++ b/date.c
> @@ -732,7 +732,7 @@ int parse_expiry_date(const char *date, unsigned long *timestamp)
> /*
> * We take over "now" here, which usually translates
> * to the current timestamp. This is because the user
> - * really means to expire everything she has done in
> + * really means to expire everything they have done in
> * the past, and by definition reflogs are the record
> * of the past, and there is nothing from the future
> * to be kept.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] date.c: phrase a comment gender neutral
2014-11-18 20:03 ` Junio C Hamano
@ 2014-11-18 20:07 ` Stefan Beller
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Beller @ 2014-11-18 20:07 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
ok.
I'll stop sending such gender related nits.
On Tue, Nov 18, 2014 at 12:03 PM, Junio C Hamano <gitster@pobox•com> wrote:
> Stefan Beller <sbeller@google•com> writes:
>
>> When looking for suitable functions to print dates,
>> I found this gem. Let's make it gender neutral as
>> nowadays people get upset by this gender debate.
>
> For some time I used to use "she/her" on Mondays, Wednesdays and
> Fridays and "he/his" on other days to balance them, and you are
> seeing the artifact of that.
>
> Some people might feel that we would be better off using "they" all
> the time, but IMO it's such a minor thing that once it _is_ in the
> tree, it's not really worth the patch noise to go and fix it up.
>
>
>>
>> Signed-off-by: Stefan Beller <sbeller@google•com>
>> ---
>> date.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/date.c b/date.c
>> index 59dfe57..19fb439 100644
>> --- a/date.c
>> +++ b/date.c
>> @@ -732,7 +732,7 @@ int parse_expiry_date(const char *date, unsigned long *timestamp)
>> /*
>> * We take over "now" here, which usually translates
>> * to the current timestamp. This is because the user
>> - * really means to expire everything she has done in
>> + * really means to expire everything they have done in
>> * the past, and by definition reflogs are the record
>> * of the past, and there is nothing from the future
>> * to be kept.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-18 20:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-18 19:24 [PATCH] date.c: phrase a comment gender neutral Stefan Beller
2014-11-18 19:42 ` Jonathan Nieder
2014-11-18 20:03 ` Junio C Hamano
2014-11-18 20:07 ` Stefan Beller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox