From: Jeff King <peff@peff•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: Eric Blake <eblake@redhat•com>,
Stefan Hajnoczi <stefanha@gmail•com>,
Zhu Guihua <zhugh.fnst@cn•fujitsu.com>,
qemu-devel@nongnu•org, tangchen@cn•fujitsu.com,
chen.fan.fnst@cn•fujitsu.com, isimatu.yasuaki@jp•fujitsu.com,
imammedo@redhat•com, guz.fnst@cn•fujitsu.com,
anshul.makkar@profitbricks•com, afaerber@suse•de,
git@vger•kernel.org
Subject: Re: [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support
Date: Fri, 6 Feb 2015 14:33:49 -0500 [thread overview]
Message-ID: <20150206193349.GB4220@peff.net> (raw)
In-Reply-To: <xmqq61bgkt9w.fsf@gitster.dls.corp.google.com>
On Thu, Feb 05, 2015 at 12:17:15PM -0800, Junio C Hamano wrote:
> > Would "length() > 1" be enough[1]? Or are people really typing "yes" and
> > not just "y"?
> >
> > I cannot imagine a charset name that is smaller than two characters. It
> > may be that there are none smaller than 4, and we could cut it off
> > there. Googling around for some lists of common charsets, it seems like
> > that might be plausible (but not any larger; "big5" is 4 characters, and
> > people may spell "utf8" without the hyphen).
> >
> > -Peff
> >
> > [1] Of course, to match the existing regex code, we may want to spell
> > this as "/../" or "/..../".
>
> Perhaps. Just in case there were shorter ones, something like this
> with confirm_only to allow them to say "Yes, I do mean 'xx'"?
>
> git-send-email.perl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 3092ab3..848f176 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -752,6 +752,7 @@ sub file_declares_8bit_cte {
> print " $f\n";
> }
> $auto_8bit_encoding = ask("Which 8bit encoding should I declare [UTF-8]? ",
> + valid_re => qr/.{4}/, confirm_only => 1,
> default => "UTF-8");
> }
Yes, I think leaving an escape hatch is a good idea, just in case.
-Peff
next prev parent reply other threads:[~2015-02-06 19:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1421214154.git.zhugh.fnst@cn.fujitsu.com>
[not found] ` <20150205114914.GA10126@stefanha-thinkpad.redhat.com>
2015-02-05 15:25 ` [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support Eric Blake
2015-02-05 19:29 ` Junio C Hamano
2015-02-05 19:57 ` Jeff King
2015-02-05 20:17 ` Junio C Hamano
2015-02-04 9:07 ` Invalid responses to 8bit encoding and In-Reply-To questions Geert Uytterhoeven
2015-02-04 18:34 ` Junio C Hamano
2015-04-01 10:53 ` Guilhem Bichot
2015-04-01 18:03 ` Junio C Hamano
2015-02-06 19:33 ` Jeff King [this message]
2015-02-16 22:34 ` [PATCH] send-email: ask confirmation if given encoding name is very short Junio C Hamano
2015-02-18 18:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150206193349.GB4220@peff.net \
--to=peff@peff$(echo .)net \
--cc=afaerber@suse$(echo .)de \
--cc=anshul.makkar@profitbricks$(echo .)com \
--cc=chen.fan.fnst@cn$(echo .)fujitsu.com \
--cc=eblake@redhat$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=guz.fnst@cn$(echo .)fujitsu.com \
--cc=imammedo@redhat$(echo .)com \
--cc=isimatu.yasuaki@jp$(echo .)fujitsu.com \
--cc=qemu-devel@nongnu$(echo .)org \
--cc=stefanha@gmail$(echo .)com \
--cc=tangchen@cn$(echo .)fujitsu.com \
--cc=zhugh.fnst@cn$(echo .)fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox