From: Junio C Hamano <gitster@pobox•com>
To: git@vger•kernel.org
Cc: Eric Blake <eblake@redhat•com>,
Stefan Hajnoczi <stefanha@gmail•com>,
Zhu Guihua <zhugh.fnst@cn•fujitsu.com>,
qemu-devel@nongnu•org, tangchen@cn•fujitsu.com,
chen.fan.fnst@cn•fujitsu.com, isimatu.yasuaki@jp•fujitsu.com,
imammedo@redhat•com, guz.fnst@cn•fujitsu.com,
anshul.makkar@profitbricks•com, afaerber@suse•de,
Jeff King <peff@peff•net>,
Geert Uytterhoeven <geert@linux-m68k•org>
Subject: [PATCH] send-email: ask confirmation if given encoding name is very short
Date: Mon, 16 Feb 2015 14:34:14 -0800 [thread overview]
Message-ID: <xmqqiof14hax.fsf_-_@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150206193349.GB4220@peff.net> (Jeff King's message of "Fri, 6 Feb 2015 14:33:49 -0500")
Sometimes people respond "y<ENTER>" (or "yes<ENTER>") when asked
this question:
Which 8bit encoding should I declare [UTF-8]?
We already have a mechanism to avoid accepting a mistyped e-mail
address (we ask to confirm when the given address lacks "@" in it);
reuse it to trigger the same confirmation when given a very short
answer. As a typical charset name is probably at least 4 chars or
longer (e.g. "UTF8" spelled without the dash, or "Big5"), this would
prevent such a mistake.
Signed-off-by: Junio C Hamano <gitster@pobox•com>
---
* Will mark to be merged to 'next'.
git-send-email.perl | 1 +
1 file changed, 1 insertion(+)
diff --git a/git-send-email.perl b/git-send-email.perl
index fdb0029..eb32371 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -733,6 +733,7 @@ sub file_declares_8bit_cte {
print " $f\n";
}
$auto_8bit_encoding = ask("Which 8bit encoding should I declare [UTF-8]? ",
+ valid_re => qr/.{4}/, confirm_only => 1,
default => "UTF-8");
}
--
2.3.0-282-gf18c841
next prev parent reply other threads:[~2015-02-16 22:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1421214154.git.zhugh.fnst@cn.fujitsu.com>
[not found] ` <20150205114914.GA10126@stefanha-thinkpad.redhat.com>
2015-02-05 15:25 ` [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support Eric Blake
2015-02-05 19:29 ` Junio C Hamano
2015-02-05 19:57 ` Jeff King
2015-02-05 20:17 ` Junio C Hamano
2015-02-04 9:07 ` Invalid responses to 8bit encoding and In-Reply-To questions Geert Uytterhoeven
2015-02-04 18:34 ` Junio C Hamano
2015-04-01 10:53 ` Guilhem Bichot
2015-04-01 18:03 ` Junio C Hamano
2015-02-06 19:33 ` [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support Jeff King
2015-02-16 22:34 ` Junio C Hamano [this message]
2015-02-18 18:58 ` [PATCH] send-email: ask confirmation if given encoding name is very short Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqiof14hax.fsf_-_@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=afaerber@suse$(echo .)de \
--cc=anshul.makkar@profitbricks$(echo .)com \
--cc=chen.fan.fnst@cn$(echo .)fujitsu.com \
--cc=eblake@redhat$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=guz.fnst@cn$(echo .)fujitsu.com \
--cc=imammedo@redhat$(echo .)com \
--cc=isimatu.yasuaki@jp$(echo .)fujitsu.com \
--cc=peff@peff$(echo .)net \
--cc=qemu-devel@nongnu$(echo .)org \
--cc=stefanha@gmail$(echo .)com \
--cc=tangchen@cn$(echo .)fujitsu.com \
--cc=zhugh.fnst@cn$(echo .)fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox