From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Eric Blake <eblake@redhat•com>,
Stefan Hajnoczi <stefanha@gmail•com>,
Zhu Guihua <zhugh.fnst@cn•fujitsu.com>,
qemu-devel@nongnu•org, tangchen@cn•fujitsu.com,
chen.fan.fnst@cn•fujitsu.com, isimatu.yasuaki@jp•fujitsu.com,
imammedo@redhat•com, guz.fnst@cn•fujitsu.com,
anshul.makkar@profitbricks•com, afaerber@suse•de,
git@vger•kernel.org
Subject: Re: [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support
Date: Thu, 05 Feb 2015 12:17:15 -0800 [thread overview]
Message-ID: <xmqq61bgkt9w.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150205195758.GC15326@peff.net> (Jeff King's message of "Thu, 5 Feb 2015 14:57:58 -0500")
Jeff King <peff@peff•net> writes:
> On Thu, Feb 05, 2015 at 11:29:07AM -0800, Junio C Hamano wrote:
>
>> Eric Blake <eblake@redhat•com> writes:
>>
>> > On 02/05/2015 04:49 AM, Stefan Hajnoczi wrote:
>> >> On Wed, Jan 14, 2015 at 03:27:23PM +0800, Zhu Guihua wrote:
>> >>> This series is based on the previous patchset from Chen Fan:
>> >>> https://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg02360.html
>> >>
>> >> This email has an invalid charset:
>> >> Content-Type: text/plain; charset="y"
>> >>
>> >> I guess you entered "y" when asked how the message was encoded.
>> >>
>> >> Please don't do that, it means we can only guess at the charset.
>> >
>> > In the past, people made a similar problem when 'git send-email' was
>> > asking if a message was in-reply-to something else (the number of
>> > messages incorrectly threaded to a message-id of 'y' or 'n' was evidence
>> > of the poor quality of the question). git.git commit 51bbccfd1b4a
>> > corrected that problem. Sounds like charset encoding is another case
>> > where the interactive parser should be taught to balk at nonsense
>> > encoding answers?
>>
>> I think I answered this in $gmane/263354; care to come up with a
>> plausible valid_re? It is inpractical to attempt to cover all valid
>> charset names, so whatever you do I'd imagine you would want to pass
>> the confirm_only parameter set to true.
>
> Would "length() > 1" be enough[1]? Or are people really typing "yes" and
> not just "y"?
>
> I cannot imagine a charset name that is smaller than two characters. It
> may be that there are none smaller than 4, and we could cut it off
> there. Googling around for some lists of common charsets, it seems like
> that might be plausible (but not any larger; "big5" is 4 characters, and
> people may spell "utf8" without the hyphen).
>
> -Peff
>
> [1] Of course, to match the existing regex code, we may want to spell
> this as "/../" or "/..../".
Perhaps. Just in case there were shorter ones, something like this
with confirm_only to allow them to say "Yes, I do mean 'xx'"?
git-send-email.perl | 1 +
1 file changed, 1 insertion(+)
diff --git a/git-send-email.perl b/git-send-email.perl
index 3092ab3..848f176 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -752,6 +752,7 @@ sub file_declares_8bit_cte {
print " $f\n";
}
$auto_8bit_encoding = ask("Which 8bit encoding should I declare [UTF-8]? ",
+ valid_re => qr/.{4}/, confirm_only => 1,
default => "UTF-8");
}
next prev parent reply other threads:[~2015-02-05 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1421214154.git.zhugh.fnst@cn.fujitsu.com>
[not found] ` <20150205114914.GA10126@stefanha-thinkpad.redhat.com>
2015-02-05 15:25 ` [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support Eric Blake
2015-02-05 19:29 ` Junio C Hamano
2015-02-05 19:57 ` Jeff King
2015-02-05 20:17 ` Junio C Hamano [this message]
2015-02-04 9:07 ` Invalid responses to 8bit encoding and In-Reply-To questions Geert Uytterhoeven
2015-02-04 18:34 ` Junio C Hamano
2015-04-01 10:53 ` Guilhem Bichot
2015-04-01 18:03 ` Junio C Hamano
2015-02-06 19:33 ` [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support Jeff King
2015-02-16 22:34 ` [PATCH] send-email: ask confirmation if given encoding name is very short Junio C Hamano
2015-02-18 18:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq61bgkt9w.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=afaerber@suse$(echo .)de \
--cc=anshul.makkar@profitbricks$(echo .)com \
--cc=chen.fan.fnst@cn$(echo .)fujitsu.com \
--cc=eblake@redhat$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=guz.fnst@cn$(echo .)fujitsu.com \
--cc=imammedo@redhat$(echo .)com \
--cc=isimatu.yasuaki@jp$(echo .)fujitsu.com \
--cc=peff@peff$(echo .)net \
--cc=qemu-devel@nongnu$(echo .)org \
--cc=stefanha@gmail$(echo .)com \
--cc=tangchen@cn$(echo .)fujitsu.com \
--cc=zhugh.fnst@cn$(echo .)fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox