public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Patrick Steinhardt" <ps@pks•im>,
	"Phillip Wood" <phillip.wood@dunelm•org.uk>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 2/2] builtin/init-db: deprecate alias for git-init(1)
Date: Mon, 01 Jun 2026 23:23:44 +0200	[thread overview]
Message-ID: <2e266786-4ccd-4300-9b53-6f13fbaa2933@app.fastmail.com> (raw)
In-Reply-To: <ah2VL-ftCQelNoOc@pks.im>

By the way I tried to find user mentions of git-init-db(1) on the
mailing list. (First git then I tried *all* but the results did not seem
dissimilar at all.) All I found was from last year[1] but the command
was used as a bug reproducer, which hints at some finger memory.

🔗 1: https://lore.kernel.org/git/d8c1df4e-a4d7-4c4c-be44-b13de3d9ffea@markus-raab.org/

On Mon, Jun 1, 2026, at 16:20, Patrick Steinhardt wrote:
> On Mon, Jun 01, 2026 at 02:48:05PM +0100, Phillip Wood wrote:
>>[snip
>>
>> Deprecating this command seems very sensible to me. As well as marking it
>> deprecated, do we want to print a warning when it is run? I imagine anyone
>> who has this command in their muscle memory is unlikely to be reading the
>> man page on a regular basis so wont see the warning there.
>
> I was wondering whether we want to call `you_still_use_that()` here.

As-is that will arguably promote the *breaking change* to right now
since it’s a `die(...)` function. That could be changed to be warn/die
modular of course.

But a simple warning message can just tell them to use git-init(1).

> I found it to be a bit heavy-handed as it's so trivial to replace with
> git-init(1), but on the other hand it's a trivial thing to do.

I imagine that most potential git-init-db(1) uses will be buried in some
scripts that haven’t been touched in years. Then the Git init might
fail, you get errors about git-commit(1) or something not being a thing
you can run without a repository, and it ends up being a headscratcher
since the original failure gets lost.

All to say I think a simple warning would be nice. ;)

  reply	other threads:[~2026-06-01 21:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01  7:55 [PATCH 0/2] Deprecate git-init-db(1) alias Patrick Steinhardt
2026-06-01  7:55 ` [PATCH 1/2] builtin/init-db: rename to "builtin/init.c" Patrick Steinhardt
2026-06-01  7:56 ` [PATCH 2/2] builtin/init-db: deprecate alias for git-init(1) Patrick Steinhardt
2026-06-01  9:31   ` Kristoffer Haugsbakk
2026-06-01 12:10     ` Patrick Steinhardt
2026-06-01 13:48       ` Phillip Wood
2026-06-01 14:20         ` Patrick Steinhardt
2026-06-01 21:23           ` Kristoffer Haugsbakk [this message]
2026-06-01 22:22             ` Junio C Hamano
2026-06-02  6:45               ` Patrick Steinhardt
2026-06-02  7:54                 ` Kristoffer Haugsbakk
2026-06-02 12:34                   ` Patrick Steinhardt
2026-06-02  8:27                 ` Junio C Hamano
2026-06-02 12:34                   ` Patrick Steinhardt
2026-06-02 13:12                     ` Phillip Wood
2026-06-02 14:58                       ` Patrick Steinhardt
2026-06-02 15:24                     ` SZEDER Gábor
2026-06-01 22:18           ` Junio C Hamano
2026-06-02 13:09           ` Phillip Wood
2026-06-02 13:50             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e266786-4ccd-4300-9b53-6f13fbaa2933@app.fastmail.com \
    --to=kristofferhaugsbakk@fastmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=phillip.wood@dunelm$(echo .)org.uk \
    --cc=ps@pks$(echo .)im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox