From: Patrick Steinhardt <ps@pks•im>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail•com>
Cc: Junio C Hamano <gitster@pobox•com>,
Phillip Wood <phillip.wood@dunelm•org.uk>,
git@vger•kernel.org
Subject: Re: [PATCH 2/2] builtin/init-db: deprecate alias for git-init(1)
Date: Tue, 2 Jun 2026 14:34:40 +0200 [thread overview]
Message-ID: <ah7N4CeYM4rozerD@pks.im> (raw)
In-Reply-To: <455fc75a-444f-4760-a22f-54a2ec29618b@app.fastmail.com>
On Tue, Jun 02, 2026 at 09:54:02AM +0200, Kristoffer Haugsbakk wrote:
> On Tue, Jun 2, 2026, at 08:45, Patrick Steinhardt wrote:
> > On Tue, Jun 02, 2026 at 07:22:50AM +0900, Junio C Hamano wrote:
> >> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com> writes:
> >>>[snip]
> >> Or just leave it without deprecation. It does not cost much to keep
> >> "init-db", and because we expanded what "git database" means in
> >> later versions of Git since its invention, the name still makes
> >> sense. Thank Linus for not naming it "init-odb"---that might have
> >> been a valid excuse to rename it because it does not cover the ref
> >> database and config database and others.
> >
> > I wouldn't mind that outcome much, either. What triggered this series is
> > that I'm always annoyed that it's "builtin/init-db.c" instead of
> > "builtin/init.c", and the same for `cmd_init_db()`. But I intentionally
> > constructed the series in a way that the first commit can be picked
> > as-is, so that we can adjust our code to the modern world while not
> > doing the deprecation dance.
> >
> > So I'd be equally happy if we just drop the second commit in this
> > series.
>
> Could it be worthwhile to mark it as soft deprecated? In the sense that
> it is a legacy alias that is not planned for removal?
The question is how such a soft deprecation would look like. Would it be
a warning, only, but other than that it behaves just as before? Should
we mark it as `DEPRECATED` in "git.c"? Both of those?
Patrick
next prev parent reply other threads:[~2026-06-02 12:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 7:55 [PATCH 0/2] Deprecate git-init-db(1) alias Patrick Steinhardt
2026-06-01 7:55 ` [PATCH 1/2] builtin/init-db: rename to "builtin/init.c" Patrick Steinhardt
2026-06-01 7:56 ` [PATCH 2/2] builtin/init-db: deprecate alias for git-init(1) Patrick Steinhardt
2026-06-01 9:31 ` Kristoffer Haugsbakk
2026-06-01 12:10 ` Patrick Steinhardt
2026-06-01 13:48 ` Phillip Wood
2026-06-01 14:20 ` Patrick Steinhardt
2026-06-01 21:23 ` Kristoffer Haugsbakk
2026-06-01 22:22 ` Junio C Hamano
2026-06-02 6:45 ` Patrick Steinhardt
2026-06-02 7:54 ` Kristoffer Haugsbakk
2026-06-02 12:34 ` Patrick Steinhardt [this message]
2026-06-02 8:27 ` Junio C Hamano
2026-06-02 12:34 ` Patrick Steinhardt
2026-06-02 13:12 ` Phillip Wood
2026-06-02 14:58 ` Patrick Steinhardt
2026-06-02 15:24 ` SZEDER Gábor
2026-06-01 22:18 ` Junio C Hamano
2026-06-02 13:09 ` Phillip Wood
2026-06-02 13:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah7N4CeYM4rozerD@pks.im \
--to=ps@pks$(echo .)im \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox