From: Phillip Wood <phillip.wood123@gmail•com>
To: Patrick Steinhardt <ps@pks•im>, Junio C Hamano <gitster@pobox•com>
Cc: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail•com>,
Phillip Wood <phillip.wood@dunelm•org.uk>,
git@vger•kernel.org
Subject: Re: [PATCH 2/2] builtin/init-db: deprecate alias for git-init(1)
Date: Tue, 2 Jun 2026 14:12:58 +0100 [thread overview]
Message-ID: <e6e225e7-f915-4ed0-900d-03a7767fb36f@gmail.com> (raw)
In-Reply-To: <ah7N5bKAiAORtNkp@pks.im>
On 02/06/2026 13:34, Patrick Steinhardt wrote:
>
> That's entirely fair. My take on this is a bit different, as I think
> it's beneficial to accept a short-term adjustment for core contributors
> in favor of making stuff easier to discover/maintain going forward.
> > A new contributor would probably be quick to learn that every
> `cmd_foo()` entry point is named exactly the same as the subcommand
> name, but they will then eventually trip over the few exceptions like
> `cmd_init_db()` where that assumption doesn't hold.
Yes, those exceptions to the rule are annoying. Though they mostly exist
for a good reason (code sharing between builtin commands), it would be
nice to minimize them where we can.
Thanks
Phillip
next prev parent reply other threads:[~2026-06-02 13:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 7:55 [PATCH 0/2] Deprecate git-init-db(1) alias Patrick Steinhardt
2026-06-01 7:55 ` [PATCH 1/2] builtin/init-db: rename to "builtin/init.c" Patrick Steinhardt
2026-06-01 7:56 ` [PATCH 2/2] builtin/init-db: deprecate alias for git-init(1) Patrick Steinhardt
2026-06-01 9:31 ` Kristoffer Haugsbakk
2026-06-01 12:10 ` Patrick Steinhardt
2026-06-01 13:48 ` Phillip Wood
2026-06-01 14:20 ` Patrick Steinhardt
2026-06-01 21:23 ` Kristoffer Haugsbakk
2026-06-01 22:22 ` Junio C Hamano
2026-06-02 6:45 ` Patrick Steinhardt
2026-06-02 7:54 ` Kristoffer Haugsbakk
2026-06-02 12:34 ` Patrick Steinhardt
2026-06-02 8:27 ` Junio C Hamano
2026-06-02 12:34 ` Patrick Steinhardt
2026-06-02 13:12 ` Phillip Wood [this message]
2026-06-02 14:58 ` Patrick Steinhardt
2026-06-02 15:24 ` SZEDER Gábor
2026-06-01 22:18 ` Junio C Hamano
2026-06-02 13:09 ` Phillip Wood
2026-06-02 13:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6e225e7-f915-4ed0-900d-03a7767fb36f@gmail.com \
--to=phillip.wood123@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox