From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: Benoit Sigoure <tsunanet@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH] Undefine strlcpy if needed.
Date: Sun, 24 Aug 2014 12:10:16 +0100 [thread overview]
Message-ID: <53F9C818.8020607@ramsay1.demon.co.uk> (raw)
In-Reply-To: <1408854930-14322-1-git-send-email-tsunanet@gmail.com>
On 24/08/14 05:35, Benoit Sigoure wrote:
> On OS X, strlcpy is already #define'd, which causes warnings
> in all the files that include `git-compat-util.h'. Note that
> this only occurs when building without running ./configure.
>
> Signed-off-by: Benoit Sigoure <tsunanet@gmail•com>
> ---
>
> Resending with the SOB line I forgot.
>
> git-compat-util.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/git-compat-util.h b/git-compat-util.h
> index f587749..8c001e2 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -495,6 +495,9 @@ extern char *gitstrcasestr(const char *haystack, const char *needle);
> #endif
>
> #ifdef NO_STRLCPY
> +#ifdef strlcpy
> +#undef strlcpy
> +#endif
If strlcpy is #defined, then presumably NO_STRLCPY should not be set, no?
> #define strlcpy gitstrlcpy
> extern size_t gitstrlcpy(char *, const char *, size_t);
> #endif
>
Hmm, which version of OS X are we talking about?
config.mak.uname contains this:
ifeq ($(shell expr "$(uname_R)" : '[15]\.'),2)
NO_STRLCPY = YesPlease
What does ./configure put in config.mak.autogen for NO_STRLCPY?
(sorry, I don't have access to any version of OS X, so I can't
offer much help on this).
ATB,
Ramsay Jones
next prev parent reply other threads:[~2014-08-24 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-24 4:32 [PATCH] Undefine strlcpy if needed Benoit Sigoure
2014-08-24 4:35 ` Benoit Sigoure
2014-08-24 11:10 ` Ramsay Jones [this message]
2014-08-24 11:13 ` tsuna
2014-08-24 16:18 ` Ramsay Jones
2014-08-24 19:49 ` Torsten Bögershausen
2014-08-24 21:09 ` tsuna
2014-08-25 0:32 ` Ramsay Jones
2014-08-25 1:54 ` tsuna
2014-08-25 11:16 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F9C818.8020607@ramsay1.demon.co.uk \
--to=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=git@vger$(echo .)kernel.org \
--cc=tsunanet@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox