public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: tsuna <tsunanet@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Undefine strlcpy if needed.
Date: Sun, 24 Aug 2014 17:18:24 +0100	[thread overview]
Message-ID: <53FA1050.2060309@ramsay1.demon.co.uk> (raw)
In-Reply-To: <CAFKYj4dQhGgpS9Vf=5qoku49jEkR0ko7TuBNu4sQAJyiD7y+cg@mail.gmail.com>

On 24/08/14 12:13, tsuna wrote:
> On Sun, Aug 24, 2014 at 4:10 AM, Ramsay Jones
> <ramsay@ramsay1•demon.co.uk> wrote:
>> Hmm, which version of OS X are we talking about?
> 
> OS X 10.9.4:
> 
> $ uname -a
> Darwin damogran.local 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun  3
> 21:27:35 PDT 2014; root:xnu-2422.110.17~1/RELEASE_X86_64 x86_64

Hmm, does 'uname -r' return 13.3.0 or 13.4.0? (or something else!)

>> config.mak.uname contains this:
>>
>>         ifeq ($(shell expr "$(uname_R)" : '[15]\.'),2)
>>                 NO_STRLCPY = YesPlease
>>
>> What does ./configure put in config.mak.autogen for NO_STRLCPY?
> 
> NO_STRLCPY=

OK, so I've got to my limit here! ;-) The conditional shown above
(from config.mak.uname) should not have set NO_STRLCPY (assuming
that 'uname -r' is returning 13.3.0 or 13.4.0). So, unless NO_STRLCPY
is being set somewhere else (command-line, environment), this should
just work. puzzled. :(

> 
> I guess I saw all the warnings because I did just a “git pull —rebase
> && make -j8” without running “make configure && ./configure”.
> 

Yes, but use of configure is supposed to be optional ...

Hopefully, someone who actually knows OS X can solve the mystery.

ATB,
Ramsay Jones

  reply	other threads:[~2014-08-24 16:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-24  4:32 [PATCH] Undefine strlcpy if needed Benoit Sigoure
2014-08-24  4:35 ` Benoit Sigoure
2014-08-24 11:10   ` Ramsay Jones
2014-08-24 11:13     ` tsuna
2014-08-24 16:18       ` Ramsay Jones [this message]
2014-08-24 19:49         ` Torsten Bögershausen
2014-08-24 21:09           ` tsuna
2014-08-25  0:32             ` Ramsay Jones
2014-08-25  1:54               ` tsuna
2014-08-25 11:16                 ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FA1050.2060309@ramsay1.demon.co.uk \
    --to=ramsay@ramsay1$(echo .)demon.co.uk \
    --cc=git@vger$(echo .)kernel.org \
    --cc=tsunanet@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox