From: Ramsay Jones <ramsay@ramsay1•demon.co.uk>
To: tsuna <tsunanet@gmail•com>
Cc: "Torsten Bögershausen" <tboegi@web•de>, git@vger•kernel.org
Subject: Re: [PATCH] Undefine strlcpy if needed.
Date: Mon, 25 Aug 2014 12:16:04 +0100 [thread overview]
Message-ID: <53FB1AF4.1000201@ramsay1.demon.co.uk> (raw)
In-Reply-To: <CAFKYj4cDJhiVfdmzZ5KnNASBEp9bkj0asxANPv43QcMQP06z9A@mail.gmail.com>
On 25/08/14 02:54, tsuna wrote:
> On Sun, Aug 24, 2014 at 5:32 PM, Ramsay Jones
> <ramsay@ramsay1•demon.co.uk> wrote:
>> Again, I don't have access to an OS X system, so I don't know
>> which package provides libintl/gettext, but it seems to be missing
>> on your system.
>
> Probably yeah, those libraries don’t seem to be provided in standard
> with OS X or OS X’s development tools, so maybe the Makefile should
> also default to having NO_GETTEXT=YesPlease when on OS X.
>
>> You can avoid the build failure, without running configure, by
>> setting NO_GETTEXT=YesPlease in your config.mak file.
>>
>>>
>>>
>>> I need to run configure first:
>>>
>>> $ make configure
>>> GEN configure
>>> $ ./configure
>>> configure: Setting lib to 'lib' (the default)
>>> […]
>>
>> So, presumably, configure has set NO_GETEXT=YesPlease in your
>> config.mak.autogen file.
>
> Yes it did.
>
> I don’t mind running configure, but so far Git has compiled fine
> without doing it. Should we fix the default values of NO_STRLCPY /
> NO_GETEXT on OS X?
>
Is NO_STRLCPY still a problem with a fresh clone (and putting
NO_GETEXT=YesPlease in your config.mak)? I still do not understand
why you were getting those warnings; AFAICT it should not be happening!
Also, Torsten could not reproduce.
As far as NO_GETTEXT is concerned, I have to defer to someone who has
experience on that platform (I have _zero_ experience on OS X).
ATB,
Ramsay Jones
prev parent reply other threads:[~2014-08-25 11:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-24 4:32 [PATCH] Undefine strlcpy if needed Benoit Sigoure
2014-08-24 4:35 ` Benoit Sigoure
2014-08-24 11:10 ` Ramsay Jones
2014-08-24 11:13 ` tsuna
2014-08-24 16:18 ` Ramsay Jones
2014-08-24 19:49 ` Torsten Bögershausen
2014-08-24 21:09 ` tsuna
2014-08-25 0:32 ` Ramsay Jones
2014-08-25 1:54 ` tsuna
2014-08-25 11:16 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FB1AF4.1000201@ramsay1.demon.co.uk \
--to=ramsay@ramsay1$(echo .)demon.co.uk \
--cc=git@vger$(echo .)kernel.org \
--cc=tboegi@web$(echo .)de \
--cc=tsunanet@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox