From: Kelson <kelson@shysecurity•com>
To: Duy Nguyen <pclouds@gmail•com>
Cc: Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH] added git-config support for diff.relative setting
Date: Thu, 11 Dec 2014 16:41:07 -0500 [thread overview]
Message-ID: <548A0F73.80109@shysecurity.com> (raw)
In-Reply-To: <CACsJy8CBRzbVrKnKPACuqxLw2N3PiK2O2nE4-C_3jfEp6-2p=g@mail.gmail.com>
That is quite manageable. I was concerned that --relative changes the UI
(relative paths) and behavior (excluding files outside the current
directory), which might not be clear if placed in just the UI component.
You make a great point that git_diff_basic_config drives other commands
though, like git-bisect, which --relative would not effect.
-----Original Message-----
From: Duy Nguyen <pclouds@gmail•com>
Sent: 12/11/2014 08:37 AM
To: Kelson <kelson@shysecurity•com>
CC: Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH] added git-config support for diff.relative setting
On Thu, Dec 11, 2014 at 2:28 PM, Kelson <kelson@shysecurity•com> wrote:
> @@ -270,6 +270,14 @@ int git_diff_basic_config(const char *var, const char
> *value, void *cb)
> return 0;
> }
>
> + if (!strcmp(var, "diff.relative")) {
> + if (git_config_bool(var, value))
> + DIFF_OPT_SET(&default_diff_options, RELATIVE_NAME);
> + else
> + DIFF_OPT_CLR(&default_diff_options, RELATIVE_NAME);
> + return 0;
> + }
> +
> if (starts_with(var, "submodule."))
> return parse_submodule_config_option(var, value);
>
This affects more than just git-diff. git_diff_ui_config() may be a
better place.
next prev parent reply other threads:[~2014-12-11 21:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 7:28 [PATCH] added git-config support for diff.relative setting Kelson
2014-12-11 13:37 ` Duy Nguyen
2014-12-11 21:41 ` Kelson [this message]
2014-12-12 23:25 ` [PATCH v2] " Kelson
2014-12-21 20:23 ` [PATCH v3 1/2] " kelson
2014-12-30 17:56 ` kelson
2014-12-30 18:16 ` Junio C Hamano
2014-12-30 19:32 ` [PATCH 1/2] support for --no-relative and diff.relative kelson
2015-01-06 16:19 ` kelson
2015-01-07 18:09 ` Junio C Hamano
2015-01-07 18:46 ` kelson
2015-01-07 20:26 ` Junio C Hamano
2015-01-07 19:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548A0F73.80109@shysecurity.com \
--to=kelson@shysecurity$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox