From: Junio C Hamano <gitster@pobox•com>
To: kelson@shysecurity•com
Cc: Git Mailing List <git@vger•kernel.org>,
Philip Oakley <philipoakley@iee•org>,
Duy Nguyen <pclouds@gmail•com>,
Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: [PATCH v3 1/2] git-config support for diff.relative setting
Date: Tue, 30 Dec 2014 10:16:08 -0800 [thread overview]
Message-ID: <xmqqegrhrok7.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <54A2E744.8010508@shysecurity.com> (kelson@shysecurity.com's message of "Tue, 30 Dec 2014 12:56:20 -0500")
kelson@shysecurity•com writes:
> By default, git-diff shows changes and pathnames relative to the
> repository root.
> Setting diff.relative to "true" shows pathnames relative to the
> current directory
> and excludes changes outside this directory.
The above does not tell any lie, but it is mostly a description of
what "--relative" does. I think the main point of this change is
that by configuring a variable "diff.relative" (and forget about it)
you do not have to keep saying "--relative" from the command line,
so that is how you should "sell" this change to others, I think.
> ---
No signoff?
> Documentation/diff-config.txt | 5 +++++
> diff.c | 8 ++++++++
> t/t4045-diff-relative.sh | 21 +++++++++++++++++++++
> 3 files changed, 34 insertions(+)
>
> diff --git a/Documentation/diff-config.txt b/Documentation/diff-config.txt
> index b001779..496e9b0 100644
> --- a/Documentation/diff-config.txt
> +++ b/Documentation/diff-config.txt
> @@ -103,6 +103,11 @@ diff.orderfile::
> one shell glob pattern per line.
> Can be overridden by the '-O' option to linkgit:git-diff[1].
Whitespace damaged patch? HTs are all gone. Please practice first
by sending your patches to yourself, and then try to "git am" them
by saving the e-mail messages you received from yourself.
"git grep -i thunder Documentation" seem to tell me that there are
hints on using Thunderbird in SubmittingPatches and format-patch
documentation.
I might have said this already, but I think this change, without
support for "--no-relative", would be an incomplete one that can
break the end-user experience, and it would be better to swap the
order of the patches.
Thanks.
next prev parent reply other threads:[~2014-12-30 18:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 7:28 [PATCH] added git-config support for diff.relative setting Kelson
2014-12-11 13:37 ` Duy Nguyen
2014-12-11 21:41 ` Kelson
2014-12-12 23:25 ` [PATCH v2] " Kelson
2014-12-21 20:23 ` [PATCH v3 1/2] " kelson
2014-12-30 17:56 ` kelson
2014-12-30 18:16 ` Junio C Hamano [this message]
2014-12-30 19:32 ` [PATCH 1/2] support for --no-relative and diff.relative kelson
2015-01-06 16:19 ` kelson
2015-01-07 18:09 ` Junio C Hamano
2015-01-07 18:46 ` kelson
2015-01-07 20:26 ` Junio C Hamano
2015-01-07 19:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqegrhrok7.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=kelson@shysecurity$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
--cc=philipoakley@iee$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox