From: Junio C Hamano <gitster@pobox•com>
To: kelson@shysecurity•com
Cc: Git Mailing List <git@vger•kernel.org>,
Philip Oakley <philipoakley@iee•org>,
Duy Nguyen <pclouds@gmail•com>,
Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: [PATCH 1/2] support for --no-relative and diff.relative
Date: Wed, 07 Jan 2015 11:02:19 -0800 [thread overview]
Message-ID: <xmqq7fwyjtxg.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqiogijwdp.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Wed, 07 Jan 2015 10:09:22 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> Patch 2/2 also seems to share similar line-wrapping breakages that
> make it unappliable, but more importantly, the configuration that is
> supposed to correspond to --relative option only parses a boolean.
> Is that the right design, or should it also be able to substitute a
> command line `--relative=<path>` with an argument?
>
> The last was a half-way rhetorical question and my answer is that
> boolean-only is the best you could do...
> ...
> [Footnote]
>
> *1* Actually, you could declare that "diff.relative=true/" means the
> 'true/' directory while "diff.relative=true" means the boolean
> 'true' aka 'diff --relative', but I think it is too confusing.
> Let's not make it worse by going that route.
Addendum.
It was only a "half-way rhetorical question", because I am willing
to be persuaded that diff.relative=true/ vs diff.relative=true is
*not* too subtle/confusing to be a good idea, if enough people whose
judgement I trust agrees.
prev parent reply other threads:[~2015-01-07 19:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 7:28 [PATCH] added git-config support for diff.relative setting Kelson
2014-12-11 13:37 ` Duy Nguyen
2014-12-11 21:41 ` Kelson
2014-12-12 23:25 ` [PATCH v2] " Kelson
2014-12-21 20:23 ` [PATCH v3 1/2] " kelson
2014-12-30 17:56 ` kelson
2014-12-30 18:16 ` Junio C Hamano
2014-12-30 19:32 ` [PATCH 1/2] support for --no-relative and diff.relative kelson
2015-01-06 16:19 ` kelson
2015-01-07 18:09 ` Junio C Hamano
2015-01-07 18:46 ` kelson
2015-01-07 20:26 ` Junio C Hamano
2015-01-07 19:02 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7fwyjtxg.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=kelson@shysecurity$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
--cc=philipoakley@iee$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox