From: Sergei Organov <osv@javad•com>
To: "David Kågedal" <davidk@lysator•liu.se>
Cc: Andreas Schwab <schwab@linux-m68k•org>, git@vger•kernel.org
Subject: Re: git-blame.el: what is format-spec?
Date: Mon, 07 Dec 2009 11:36:19 +0300 [thread overview]
Message-ID: <87k4wzdvuk.fsf@osv.gnss.ru> (raw)
In-Reply-To: <87d42s3pv2.fsf@lysator.liu.se> ("David Kågedal"'s message of "Sun\, 06 Dec 2009 19\:43\:29 +0100")
David Kågedal <davidk@lysator•liu.se> writes:
> Sergei Organov <osv@javad•com> writes:
>
>> Then there should be (require 'format-spec) in git-blame.el, right? Due
>> to:
>
> Of course. I must have missed that since I already had it loaded.
>
>> Now, I've evaluated (require 'format-spec) in my Emacs 22 (yes, 22, not
>> 23), and now git-blame almost works there. The problem I see is that it
>> doesn't output anything in the echo area. It color-codes the buffer, it
>> does show correct pop-up when mouse is over a region, but it doesn't
>> print anything in the echo area when I move cursor through the regions.
>> Any idea how to debug/fix this?
>
> Well, it appears I removed the output to the echo area. I didn't think
> it worked very well, and the new output format mostly replaces it by
> showing the hash.
>
> There are also technical reasons for removing it (it couldn't be
> implemented very cleanly).
I didn't know you deliberately removed it, -- I thought it's some
Emacs22 - related problem. I have no problem then, except that I don't
know how to get the hash into my kill-ring or X selection.
While we are at it, why is git-blame-identify interactive and how is it
useful?
>
> It would of course be possible to restore the old way, but I think it
> would be good to ask ourselves what we really would like to see? Some
> ideas:
>
> * A keybinding to show the commit introducing the current line,
> including diff and all.
>
> * A keybinding to show the commit message in the echo areia.
For me, these 2 would be more than enough, I think.
-- Sergei.
next prev parent reply other threads:[~2009-12-07 8:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 16:21 git-blame.el: what is format-spec? Sergei Organov
2009-12-04 16:38 ` Andreas Schwab
2009-12-04 16:59 ` Sergei Organov
2009-12-04 17:36 ` David Kågedal
2009-12-04 20:54 ` Sergei Organov
2009-12-06 18:43 ` David Kågedal
2009-12-07 8:36 ` Sergei Organov [this message]
2009-12-07 9:05 ` David Kågedal
2010-05-14 13:13 ` Alex Unleashed
2010-05-25 13:44 ` [PATCH] git-blame.el: Add (require 'format-spec) David Kågedal
2010-10-29 3:38 ` [PATCH resend] " Jonathan Nieder
2011-02-04 1:43 ` git-blame.el: does not show one-line summary in echo area Jonathan Nieder
2011-02-04 9:53 ` David Kågedal
2011-02-04 10:03 ` Jakub Narebski
2011-02-04 10:15 ` David Kågedal
2011-02-04 12:26 ` David Kågedal
2011-02-11 2:29 ` Jonathan Nieder
2011-02-11 6:42 ` git-blame.el: format of date strings Jonathan Nieder
2011-02-11 7:56 ` Martin Nordholts
2012-06-10 8:24 ` [PATCH/RFC] git-blame.el: truncate author to avoid jagged left edge of code Jonathan Nieder
2013-01-29 20:17 ` David Kågedal
2011-02-04 21:49 ` git-blame.el: does not show one-line summary in echo area Kevin Ryde
2009-12-04 17:42 ` git-blame.el: what is format-spec? Andreas Schwab
2009-12-04 18:18 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4wzdvuk.fsf@osv.gnss.ru \
--to=osv@javad$(echo .)com \
--cc=davidk@lysator$(echo .)liu.se \
--cc=git@vger$(echo .)kernel.org \
--cc=schwab@linux-m68k$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox