public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: "David Kågedal" <davidk@lysator•liu.se>
To: Sergei Organov <osv@javad•com>
Cc: Andreas Schwab <schwab@linux-m68k•org>, git@vger•kernel.org
Subject: [PATCH] git-blame.el: Add (require 'format-spec)
Date: Tue, 25 May 2010 15:44:15 +0200	[thread overview]
Message-ID: <87r5l0gkpc.fsf_-_@krank.kagedal.org> (raw)
In-Reply-To: <AANLkTikPArJ0s8BTN7QH3CeqU98BGHobKax3IrjMXPrh@mail.gmail.com> (Alex Unleashed's message of "Fri, 14 May 2010 15:13:35 +0200")


---
> On Sun, Dec 6, 2009 at 8:43 PM, David Kågedal <davidk@lysator•liu.se> wrote:
> > Sergei Organov <osv@javad•com> writes:
> >
> >> Then there should be (require 'format-spec) in git-blame.el, right? Due
> >> to:
> >
> > Of course. I must have missed that since I already had it loaded.
> 
> Has this oneliner been submitted for inclusion in git.git yet?
> Yesterday I stumbled upon format-spec missing on a fresh install of
> Ubuntu 10.04's emacs package.. Just require'ing it fixes the problem.

Apparently not, but here is the patch.

 contrib/emacs/git-blame.el |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
index 7f4c792..d351cfb 100644
--- a/contrib/emacs/git-blame.el
+++ b/contrib/emacs/git-blame.el
@@ -79,6 +79,7 @@
 ;;; Code:
 
 (eval-when-compile (require 'cl))			      ; to use `push', `pop'
+(require 'format-spec)
 
 (defface git-blame-prefix-face
   '((((background dark)) (:foreground "gray"
-- 
1.7.0.4


-- 
David Kågedal

  reply	other threads:[~2010-05-25 14:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04 16:21 git-blame.el: what is format-spec? Sergei Organov
2009-12-04 16:38 ` Andreas Schwab
2009-12-04 16:59   ` Sergei Organov
2009-12-04 17:36     ` David Kågedal
2009-12-04 20:54       ` Sergei Organov
2009-12-06 18:43         ` David Kågedal
2009-12-07  8:36           ` Sergei Organov
2009-12-07  9:05             ` David Kågedal
2010-05-14 13:13           ` Alex Unleashed
2010-05-25 13:44             ` David Kågedal [this message]
2010-10-29  3:38               ` [PATCH resend] git-blame.el: Add (require 'format-spec) Jonathan Nieder
2011-02-04  1:43           ` git-blame.el: does not show one-line summary in echo area Jonathan Nieder
2011-02-04  9:53             ` David Kågedal
2011-02-04 10:03               ` Jakub Narebski
2011-02-04 10:15                 ` David Kågedal
2011-02-04 12:26                   ` David Kågedal
2011-02-11  2:29                     ` Jonathan Nieder
2011-02-11  6:42                       ` git-blame.el: format of date strings Jonathan Nieder
2011-02-11  7:56                         ` Martin Nordholts
2012-06-10  8:24                       ` [PATCH/RFC] git-blame.el: truncate author to avoid jagged left edge of code Jonathan Nieder
2013-01-29 20:17                         ` David Kågedal
2011-02-04 21:49                   ` git-blame.el: does not show one-line summary in echo area Kevin Ryde
2009-12-04 17:42     ` git-blame.el: what is format-spec? Andreas Schwab
2009-12-04 18:18       ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r5l0gkpc.fsf_-_@krank.kagedal.org \
    --to=davidk@lysator$(echo .)liu.se \
    --cc=git@vger$(echo .)kernel.org \
    --cc=osv@javad$(echo .)com \
    --cc=schwab@linux-m68k$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox