From: "David Kågedal" <davidk@lysator•liu.se>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Jakub Narebski <jnareb@gmail•com>,
Xavier Maillard <zedek@gnu•org>,
Alexandre Julliard <julliard@winehq•org>,
Martin Nordholts <enselic@gmail•com>,
Kevin Ryde <user42@zip•com.au>,
git@vger•kernel.org, Andreas Schwab <schwab@linux-m68k•org>,
Sergei Organov <osv@javad•com>
Subject: Re: git-blame.el: does not show one-line summary in echo area
Date: Fri, 04 Feb 2011 10:53:24 +0100 [thread overview]
Message-ID: <87tygkm8h7.fsf@krank.kagedal.org> (raw)
In-Reply-To: <20110204014315.GB28525@elie> (Jonathan Nieder's message of "Thu, 3 Feb 2011 19:43:26 -0600")
Jonathan Nieder <jrnieder@gmail•com> writes:
> Hi David et al,
>
> David Kågedal wrote:
>> Sergei Organov <osv@javad•com> writes:
>
>>> Now, I've evaluated (require 'format-spec) in my Emacs 22 (yes, 22, not
>>> 23), and now git-blame almost works there. The problem I see is that it
>>> doesn't output anything in the echo area. It color-codes the buffer, it
>>> does show correct pop-up when mouse is over a region, but it doesn't
>>> print anything in the echo area when I move cursor through the regions.
>>> Any idea how to debug/fix this?
>>
>> Well, it appears I removed the output to the echo area. I didn't think
>> it worked very well, and the new output format mostly replaces it by
>> showing the hash.
>>
>> There are also technical reasons for removing it (it couldn't be
>> implemented very cleanly).
>
> I don't use git-blame.el ("git blame", "git gui blame", and "git log
> -S/-G" take care of my needs already) but it seems to me that this
> change was a regression. The emacs support before v1.6.6-rc0~120^2
> had a simple way to find out the purpose of each line of code, while
> after that there is no simple way. And it is what the README
> promises:
>
> * git-blame.el:
>
> Emacs implementation of incremental git-blame. When you turn it on
> while viewing a file, the editor buffer will be updated by setting
> the background of individual lines to a color that reflects which
> commit it comes from. And when you move around the buffer, a
> one-line summary will be shown in the echo area.
>
> Any advice for people who want to fix that? Is anyone interested in
> doing so? (It is quite likely I am guessing incorrectly about what is
> useful, but I would imagine that at least the documentation could use
> updating.)
Let's try to figure out how we would like it to work. I agree that the
mouseover information is not good enough. There are several things we
can do:
1) Use some command to request information about the current line.
When the command is invoked (bound to some convenient key?), it pops
up a buffer with the result of "git show <commit>" or similar.
2) Have a separate buffer always showing information about the line
under the cursor. This should at least be the info in the commit
object, but going to the diff should be accessible.
3) Showing when you move to a different blame chunk, by showing a
one-line summary in the echo area.
There are variations and combinations. I think that 1+3 or 2 are the
best options.
--
David Kågedal
next prev parent reply other threads:[~2011-02-04 10:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 16:21 git-blame.el: what is format-spec? Sergei Organov
2009-12-04 16:38 ` Andreas Schwab
2009-12-04 16:59 ` Sergei Organov
2009-12-04 17:36 ` David Kågedal
2009-12-04 20:54 ` Sergei Organov
2009-12-06 18:43 ` David Kågedal
2009-12-07 8:36 ` Sergei Organov
2009-12-07 9:05 ` David Kågedal
2010-05-14 13:13 ` Alex Unleashed
2010-05-25 13:44 ` [PATCH] git-blame.el: Add (require 'format-spec) David Kågedal
2010-10-29 3:38 ` [PATCH resend] " Jonathan Nieder
2011-02-04 1:43 ` git-blame.el: does not show one-line summary in echo area Jonathan Nieder
2011-02-04 9:53 ` David Kågedal [this message]
2011-02-04 10:03 ` Jakub Narebski
2011-02-04 10:15 ` David Kågedal
2011-02-04 12:26 ` David Kågedal
2011-02-11 2:29 ` Jonathan Nieder
2011-02-11 6:42 ` git-blame.el: format of date strings Jonathan Nieder
2011-02-11 7:56 ` Martin Nordholts
2012-06-10 8:24 ` [PATCH/RFC] git-blame.el: truncate author to avoid jagged left edge of code Jonathan Nieder
2013-01-29 20:17 ` David Kågedal
2011-02-04 21:49 ` git-blame.el: does not show one-line summary in echo area Kevin Ryde
2009-12-04 17:42 ` git-blame.el: what is format-spec? Andreas Schwab
2009-12-04 18:18 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tygkm8h7.fsf@krank.kagedal.org \
--to=davidk@lysator$(echo .)liu.se \
--cc=enselic@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=julliard@winehq$(echo .)org \
--cc=osv@javad$(echo .)com \
--cc=schwab@linux-m68k$(echo .)org \
--cc=user42@zip$(echo .)com.au \
--cc=zedek@gnu$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox