From: greened@obbligato•org (David A. Greene)
To: Junio C Hamano <gitster@pobox•com>
Cc: dag@cray•com (David A. Greene), git@vger•kernel.org
Subject: Re: [PATCH 1/2] Allow Overriding GIT_BUILD_DIR
Date: Tue, 06 Mar 2012 08:21:39 -0600 [thread overview]
Message-ID: <87r4x5izd8.fsf@smith.obbligato.org> (raw)
In-Reply-To: <7vaa3u24lw.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 05 Mar 2012 12:08:11 -0800")
Junio C Hamano <gitster@pobox•com> writes:
>> Right. This is because you flagged an indentation issue with the
>> previous version of the patch. I think what happened is that the
>> previous version included the 1-HT (what is HT - half-tab?) spacing but
>> it "looked funny" with the additional "+" from the diff line.
>
> No, with your earlier patch, all the existing lines used horizontal
> tabs for indenting, and the line you added used runs of spaces.
> When such a hunk is shown in diff output, "+" will make it obvious
> that only the new line you added is wrong (because the initial "+"
> and " " is absorbed in the first horizontal tab for Tab-indented
> lines) and that is how I noticed and pointed out "a funny
> indentation" to you.
Hmm...when I went back to the file it indeed had horizontal tabs. Ah, I
think I know what happened. I had to cut-n-paste into an e-mail because
I couldn't get git send-email to work at the time (it apparently gives
up after failing to authenticate even if the server presents more than
one authentication method). So I think the mailer might have replaced
tabs with spaces. I don't know. In any case, it's moot.
You indicated you'd fix up the patch. I am happy to do that as well if
you want a proper re-submission. Just let me know.
-Dave
prev parent reply other threads:[~2012-03-06 14:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-04 23:23 [PATCH 1/2] Allow Overriding GIT_BUILD_DIR greened
2012-03-04 23:23 ` [PATCH 2/2] Support Out-Of-Tree Valgrind Tests greened
2012-03-05 7:53 ` Thomas Rast
2012-03-05 18:11 ` David A. Greene
2012-03-06 8:46 ` Thomas Rast
2012-03-06 14:40 ` David A. Greene
2012-03-06 18:49 ` Junio C Hamano
2012-03-06 22:12 ` David A. Greene
2012-03-06 22:21 ` Junio C Hamano
2012-03-06 22:37 ` Junio C Hamano
2012-03-06 23:00 ` David A. Greene
2012-03-06 23:12 ` Junio C Hamano
2012-03-06 22:54 ` David A. Greene
2012-03-06 18:43 ` Junio C Hamano
2012-03-05 6:33 ` [PATCH 1/2] Allow Overriding GIT_BUILD_DIR Junio C Hamano
2012-03-05 18:10 ` David A. Greene
2012-03-05 20:08 ` Junio C Hamano
2012-03-06 14:21 ` David A. Greene [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4x5izd8.fsf@smith.obbligato.org \
--to=greened@obbligato$(echo .)org \
--cc=dag@cray$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox