From: dag@cray•com (David A. Greene)
To: Thomas Rast <trast@inf•ethz.ch>
Cc: <greened@obbligato•org>, <git@vger•kernel.org>
Subject: Re: [PATCH 2/2] Support Out-Of-Tree Valgrind Tests
Date: Mon, 05 Mar 2012 12:11:56 -0600 [thread overview]
Message-ID: <nngy5re29zn.fsf@transit.us.cray.com> (raw)
In-Reply-To: <87aa3vzdoc.fsf@thomas.inf.ethz.ch> (Thomas Rast's message of "Mon, 5 Mar 2012 08:53:39 +0100")
Thomas Rast <trast@inf•ethz.ch> writes:
> greened@obbligato•org writes:
>
>> +# GIT_VALGRIND_TOOLS is the location of tools like valgrind.sh.
>> +if test -z "$GIT_VALGRIND_TOOLS"
>> +then
>> + # We allow tests to override this, in case they want to run tests
>> + # outside of t/.
>> +
>> + # For in-tree test scripts, this is in TEST_DIRECTORY/valgrind
>> + # (t/valgrind), but a test script that lives outside t/ can
>> + # set this variable to point at the right place so that it can
>> + # find t/valgrind directory that house test helpers like
>> + # valgrind.sh.
>> + GIT_VALGRIND_TOOLS="$TEST_DIRECTORY"/valgrind
>> +fi
>
> I'm a bit curious: why isn't it enough to spell that path
> $GIT_BUILD_DIR/t/valgrind instead of making it fully configurable?
For the same reason that TEST_DIRECTORY is different and unrelated from
GIT_BUILD_DIR. It's my understanding that GIT_BUILD_DIR could end up
being somewhere compeltely unrelated to where TOP_SRC/t/valgrind is.
At least that's why I introduced a new parameter.
-Dave
next prev parent reply other threads:[~2012-03-05 18:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-04 23:23 [PATCH 1/2] Allow Overriding GIT_BUILD_DIR greened
2012-03-04 23:23 ` [PATCH 2/2] Support Out-Of-Tree Valgrind Tests greened
2012-03-05 7:53 ` Thomas Rast
2012-03-05 18:11 ` David A. Greene [this message]
2012-03-06 8:46 ` Thomas Rast
2012-03-06 14:40 ` David A. Greene
2012-03-06 18:49 ` Junio C Hamano
2012-03-06 22:12 ` David A. Greene
2012-03-06 22:21 ` Junio C Hamano
2012-03-06 22:37 ` Junio C Hamano
2012-03-06 23:00 ` David A. Greene
2012-03-06 23:12 ` Junio C Hamano
2012-03-06 22:54 ` David A. Greene
2012-03-06 18:43 ` Junio C Hamano
2012-03-05 6:33 ` [PATCH 1/2] Allow Overriding GIT_BUILD_DIR Junio C Hamano
2012-03-05 18:10 ` David A. Greene
2012-03-05 20:08 ` Junio C Hamano
2012-03-06 14:21 ` David A. Greene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nngy5re29zn.fsf@transit.us.cray.com \
--to=dag@cray$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=greened@obbligato$(echo .)org \
--cc=trast@inf$(echo .)ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox