From: "David A. Greene" <dag@cray•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: Thomas Rast <trast@inf•ethz.ch>, "David A. Greene" <dag@cray•com>,
<git@vger•kernel.org>
Subject: Re: [PATCH 2/2] Support Out-Of-Tree Valgrind Tests
Date: Tue, 6 Mar 2012 16:12:31 -0600 [thread overview]
Message-ID: <87hay1fkfk.fsf@smith.obbligato.org> (raw)
In-Reply-To: <7vaa3ttvj1.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Tue, 6 Mar 2012 10:49:06 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> greened@obbligato•org (David A. Greene) writes:
>
>>> Don't we, right now, get stuff as follows:
>>>
>>> item path
>>> --------------------------------------------
>>> test-lib.sh $TEST_DIRECTORY
>>
>> Right now, yes, but it breaks for out-of-tree tests. In the out-of-tree
>> case, TEST_DIRECTORY doesn't contain test-lib.sh. For exmaple, in
>
> Could it be that the reason for the breakage is because you are
> setting TEST_DIRECTORY to the directory that contains out-of-tree
> tests, instead of $GIT_BUILD_DIR/t/ directory?
Well, yes. I thought that's what out-of-tree tests are supposed to do.
They don't live in $GIT_BUILD_DIR/t/ after all.
Perhaps I've misunderstood how the test system is supposed to work. A
table as you described in README would be most helpful. I thought
TEST_DIRECTORY is supposed to point to where the tests to run are
located.
> Shouldn't TEST_DIRECTORY merely a short-hand for GIT_BUILD_DIR/t?
> What do you find relative to $TEST_DIRECTORY that cannot be found
> relative to GIT_BUILD_DIR/t?
If that's what TEST_DIRECTORY is supposed to be, always, then it should
be stated in the comments and README. I had no idea this was an
invariant.
Thanks for clarifying!
-Dave
next prev parent reply other threads:[~2012-03-06 22:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-04 23:23 [PATCH 1/2] Allow Overriding GIT_BUILD_DIR greened
2012-03-04 23:23 ` [PATCH 2/2] Support Out-Of-Tree Valgrind Tests greened
2012-03-05 7:53 ` Thomas Rast
2012-03-05 18:11 ` David A. Greene
2012-03-06 8:46 ` Thomas Rast
2012-03-06 14:40 ` David A. Greene
2012-03-06 18:49 ` Junio C Hamano
2012-03-06 22:12 ` David A. Greene [this message]
2012-03-06 22:21 ` Junio C Hamano
2012-03-06 22:37 ` Junio C Hamano
2012-03-06 23:00 ` David A. Greene
2012-03-06 23:12 ` Junio C Hamano
2012-03-06 22:54 ` David A. Greene
2012-03-06 18:43 ` Junio C Hamano
2012-03-05 6:33 ` [PATCH 1/2] Allow Overriding GIT_BUILD_DIR Junio C Hamano
2012-03-05 18:10 ` David A. Greene
2012-03-05 20:08 ` Junio C Hamano
2012-03-06 14:21 ` David A. Greene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hay1fkfk.fsf@smith.obbligato.org \
--to=dag@cray$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=trast@inf$(echo .)ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox