From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Aleksey Mokhovikov <moxobukob@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()
Date: Mon, 17 Mar 2014 11:01:15 +0100 [thread overview]
Message-ID: <vpqd2hlrvo4.fsf@anie.imag.fr> (raw)
In-Reply-To: <1395050104-19152-1-git-send-email-moxobukob@gmail.com> (Aleksey Mokhovikov's message of "Mon, 17 Mar 2014 16:55:04 +0700")
Hi,
Aleksey Mokhovikov <moxobukob@gmail•com> writes:
> This is a milliproject from git google summer of code page. The
> current code that selects the output message is quite easy to
> understand. So I tried to improve it by removing nested conditions and
> code duplication. The output string is generated by selecting the
> proper parts of the message and concatenating them the into one
> template string.
Please, read the threads for other submissions for this microproject.
Most remarks done there also apply for your case. See for example:
http://thread.gmane.org/gmane.comp.version-control.git/244210
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2014-03-17 10:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 9:55 [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config() Aleksey Mokhovikov
2014-03-17 10:01 ` Matthieu Moy [this message]
2014-03-18 14:42 ` Aleksey Mokhovikov
2014-03-17 10:53 ` Eric Sunshine
2014-03-18 14:37 ` Aleksey Mokhovikov
2014-03-18 12:22 ` Aleksey Mokhovikov
2014-03-18 14:33 ` Aleksey Mokhovikov
2014-03-19 9:21 ` Eric Sunshine
2014-03-20 11:56 ` Aleksey Mokhovikov
2014-03-21 4:03 ` Eric Sunshine
2014-03-21 17:09 ` Junio C Hamano
2014-03-21 21:13 ` Michael Haggerty
2014-03-21 21:33 ` Eric Sunshine
2014-03-21 21:45 ` Michael Haggerty
2014-03-24 7:28 ` Aleksey Mokhovikov
2014-03-24 12:22 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqd2hlrvo4.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=moxobukob@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox