public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Aleksey Mokhovikov <moxobukob@gmail•com>
To: git@vger•kernel.org
Subject: Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()
Date: Tue, 18 Mar 2014 21:37:39 +0700	[thread overview]
Message-ID: <lg9l9t$uaa$1@ger.gmane.org> (raw)
In-Reply-To: <CAPig+cQ_gvDWKkgN543TZtfGOqDkH0EYS39w+eEw8CdJO9Ux3Q@mail.gmail.com>

Eric Sunshine <sunshine <at> sunshineco.com> writes:

> The subject should be concise. Try to keep it at 65-70 characters or
> less. More detailed information can be written following the subject
> (separated from the subject by a blank line).
>
> Write in imperative tone: say "replace X with Y" rather than "X is
> replaced with Y".
>
> Mention the module or function you're touching.
>
> You might say something like this:
>
>     Subject: install_branch_config: replace if-chain with string composition
> Wrap lines to 65-70 characters.
>
> This prose is almost pure email commentary. It doesn't really convey
> useful information to a person reading the patch months or years from
> now. Place commentary below the "---" line under your sign-off.

Thanks a lot for you language and message formatting style advices.

I've make a new patch taking into account the GNU gettext requirements.
I don't know if I should create a new thread for another patch, but

I'd be glad if you will give me some information about new patch:
http://permalink.gmane.org/gmane.comp.version-control.git/244357

next prev parent reply	other threads:[~2014-03-18 14:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-17  9:55 [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config() Aleksey Mokhovikov
2014-03-17 10:01 ` Matthieu Moy
2014-03-18 14:42   ` Aleksey Mokhovikov
2014-03-17 10:53 ` Eric Sunshine
2014-03-18 14:37   ` Aleksey Mokhovikov [this message]
2014-03-18 12:22 ` Aleksey Mokhovikov
2014-03-18 14:33   ` Aleksey Mokhovikov
2014-03-19  9:21     ` Eric Sunshine
2014-03-20 11:56       ` Aleksey Mokhovikov
2014-03-21  4:03         ` Eric Sunshine
2014-03-21 17:09           ` Junio C Hamano
2014-03-21 21:13             ` Michael Haggerty
2014-03-21 21:33               ` Eric Sunshine
2014-03-21 21:45                 ` Michael Haggerty
2014-03-24  7:28               ` Aleksey Mokhovikov
2014-03-24 12:22                 ` Michael Haggerty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='lg9l9t$uaa$1@ger.gmane.org' \
    --to=moxobukob@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox