From: Junio C Hamano <gitster@pobox•com>
To: Eric Sunshine <sunshine@sunshineco•com>
Cc: Aleksey Mokhovikov <moxobukob@gmail•com>, Git List <git@vger•kernel.org>
Subject: Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()
Date: Fri, 21 Mar 2014 10:09:19 -0700 [thread overview]
Message-ID: <xmqqr45vv5q8.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cRv-WvoMVY0PDgtLawywe0QfpX8oPetzNwD-9Jq6BOjyw@mail.gmail.com> (Eric Sunshine's message of "Fri, 21 Mar 2014 00:03:28 -0400")
Eric Sunshine <sunshine@sunshineco•com> writes:
> Sorry, you're right about message[0] case not being a crasher (though
> the assert() still seems overkill).
Assert() often becomes no-op in production build. I think this may
be an indication that "table-driven" may not be as good an approach
as many candidates thought. The microproject suggestion asks them
to think _if_ that makes sense, and it is perfectly fine for them if
they answer "no, it introduces more problems than it solves".
next prev parent reply other threads:[~2014-03-21 17:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 9:55 [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config() Aleksey Mokhovikov
2014-03-17 10:01 ` Matthieu Moy
2014-03-18 14:42 ` Aleksey Mokhovikov
2014-03-17 10:53 ` Eric Sunshine
2014-03-18 14:37 ` Aleksey Mokhovikov
2014-03-18 12:22 ` Aleksey Mokhovikov
2014-03-18 14:33 ` Aleksey Mokhovikov
2014-03-19 9:21 ` Eric Sunshine
2014-03-20 11:56 ` Aleksey Mokhovikov
2014-03-21 4:03 ` Eric Sunshine
2014-03-21 17:09 ` Junio C Hamano [this message]
2014-03-21 21:13 ` Michael Haggerty
2014-03-21 21:33 ` Eric Sunshine
2014-03-21 21:45 ` Michael Haggerty
2014-03-24 7:28 ` Aleksey Mokhovikov
2014-03-24 12:22 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr45vv5q8.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=moxobukob@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox