public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: "Christian Couder" <christian.couder@gmail•com>,
	"Arjun Sreedharan" <arjun024@gmail•com>,
	git <git@vger•kernel.org>,
	"Christian Couder" <chriscool@tuxfamily•org>,
	"Nguyễn Thái Ngọc" <pclouds@gmail•com>
Subject: Re: [PATCH 2/3] log-tree: make name_decoration hash static
Date: Tue, 26 Aug 2014 10:40:10 -0700	[thread overview]
Message-ID: <xmqq38cjjgjp.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140826102353.GB25687@peff.net> (Jeff King's message of "Tue, 26 Aug 2014 06:23:54 -0400")

Jeff King <peff@peff•net> writes:

> In the previous commit, we made add_name_decoration global
> so that adders would not have to access the hash directly.
> We now make the hash itself static so that callers _have_ to
> add through our function, making sure that all additions go
> through a single point.  To do this, we have to add one more
> accessor function: a way to lookup entries in the hash.
>
> Since the only caller doesn't actually look at the returned
> value, but rather only asks whether there is a decoration or
> not, we could provide only a boolean "has_name_decoration".
> That would allow us to make "struct name_decoration" local
> to log-tree, as well.
>
> However, it's unlikely to cause any maintainability harm
> making the actual data public, and this interface is more
> flexible if we need to look at decorations from other parts
> of the code in the future.

I didn't think we want only-bool version, but it is nice to see it
explained well.

I may have called it lookup_name_decoration() to match, though, if I
were doing this patch ;-)

Thanks.

next prev parent reply	other threads:[~2014-08-26 17:40 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-24 14:17 [PATCH] bisect: save heap memory. allocate only the required amount Arjun Sreedharan
2014-08-24 15:10 ` Stefan Beller
2014-08-24 23:39   ` Junio C Hamano
2014-08-25 13:07     ` Jeff King
2014-08-25 21:36       ` Junio C Hamano
2014-08-26 11:03         ` Jeff King
2014-08-26 11:57           ` Ramsay Jones
2014-08-26 12:14             ` Jeff King
2014-08-26 12:37               ` Ramsay Jones
2014-08-26 12:43                 ` Jeff King
2014-08-26 12:59                   ` Ramsay Jones
2014-08-24 15:32 ` Ramsay Jones
2014-08-24 21:55   ` Arjun Sreedharan
2014-08-25 13:35 ` Jeff King
2014-08-25 14:06   ` Christian Couder
2014-08-25 15:00     ` Jeff King
2014-08-25 18:26       ` Junio C Hamano
2014-08-25 19:35         ` Jeff King
2014-08-25 20:27           ` Arjun Sreedharan
2014-08-25 21:11           ` Junio C Hamano
2014-08-26 10:20             ` [PATCH 0/3] name_decoration cleanups Jeff King
2014-08-26 10:23               ` [PATCH 1/3] log-tree: make add_name_decoration a public function Jeff King
2014-08-26 11:48                 ` Ramsay Jones
2014-08-26 12:17                   ` Jeff King
2014-08-26 10:23               ` [PATCH 2/3] log-tree: make name_decoration hash static Jeff King
2014-08-26 17:40                 ` Junio C Hamano [this message]
2014-08-26 17:43                   ` Jeff King
2014-08-26 19:25                     ` Junio C Hamano
2014-08-26 10:24               ` [PATCH 3/3] log-tree: use FLEX_ARRAY in name_decoration Jeff King
2014-08-27  0:30                 ` Eric Sunshine
2014-08-25 21:14 ` [PATCH] bisect: save heap memory. allocate only the required amount Junio C Hamano
2014-08-26  7:30   ` Arjun Sreedharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq38cjjgjp.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=arjun024@gmail$(echo .)com \
    --cc=chriscool@tuxfamily$(echo .)org \
    --cc=christian.couder@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=pclouds@gmail$(echo .)com \
    --cc=peff@peff$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox