From: Junio C Hamano <gitster@pobox•com>
To: Arjun Sreedharan <arjun024@gmail•com>
Cc: git@vger•kernel.org, "Christian Couder" <chriscool@tuxfamily•org>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>
Subject: Re: [PATCH] bisect: save heap memory. allocate only the required amount
Date: Mon, 25 Aug 2014 14:14:34 -0700 [thread overview]
Message-ID: <xmqqd2bol1ad.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1408889844-5407-1-git-send-email-arjun024@gmail.com> (Arjun Sreedharan's message of "Sun, 24 Aug 2014 19:47:24 +0530")
Arjun Sreedharan <arjun024@gmail•com> writes:
> Find and allocate the required amount instead of allocating extra
> 100 bytes
>
> Signed-off-by: Arjun Sreedharan <arjun024@gmail•com>
> ---
Interesting. How much memory do we typically waste (in other words,
how big did "cnt" grew in your repository where you noticed this)?
> bisect.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/bisect.c b/bisect.c
> index d6e851d..c96aab0 100644
> --- a/bisect.c
> +++ b/bisect.c
> @@ -215,10 +215,13 @@ static struct commit_list *best_bisection_sorted(struct commit_list *list, int n
> }
> qsort(array, cnt, sizeof(*array), compare_commit_dist);
> for (p = list, i = 0; i < cnt; i++) {
> - struct name_decoration *r = xmalloc(sizeof(*r) + 100);
> + char name[100];
> + sprintf(name, "dist=%d", array[i].distance);
> + int name_len = strlen(name);
Decl-after-stmt.
You do not have to run a separate strlen() for this. The return
value from sprintf() should tell you how much you need to allocate,
I think.
> + struct name_decoration *r = xmalloc(sizeof(*r) + name_len);
> struct object *obj = &(array[i].commit->object);
>
> - sprintf(r->name, "dist=%d", array[i].distance);
> + memcpy(r->name, name, name_len + 1);
> r->next = add_decoration(&name_decoration, obj, r);
> p->item = array[i].commit;
> p = p->next;
next prev parent reply other threads:[~2014-08-25 21:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-24 14:17 [PATCH] bisect: save heap memory. allocate only the required amount Arjun Sreedharan
2014-08-24 15:10 ` Stefan Beller
2014-08-24 23:39 ` Junio C Hamano
2014-08-25 13:07 ` Jeff King
2014-08-25 21:36 ` Junio C Hamano
2014-08-26 11:03 ` Jeff King
2014-08-26 11:57 ` Ramsay Jones
2014-08-26 12:14 ` Jeff King
2014-08-26 12:37 ` Ramsay Jones
2014-08-26 12:43 ` Jeff King
2014-08-26 12:59 ` Ramsay Jones
2014-08-24 15:32 ` Ramsay Jones
2014-08-24 21:55 ` Arjun Sreedharan
2014-08-25 13:35 ` Jeff King
2014-08-25 14:06 ` Christian Couder
2014-08-25 15:00 ` Jeff King
2014-08-25 18:26 ` Junio C Hamano
2014-08-25 19:35 ` Jeff King
2014-08-25 20:27 ` Arjun Sreedharan
2014-08-25 21:11 ` Junio C Hamano
2014-08-26 10:20 ` [PATCH 0/3] name_decoration cleanups Jeff King
2014-08-26 10:23 ` [PATCH 1/3] log-tree: make add_name_decoration a public function Jeff King
2014-08-26 11:48 ` Ramsay Jones
2014-08-26 12:17 ` Jeff King
2014-08-26 10:23 ` [PATCH 2/3] log-tree: make name_decoration hash static Jeff King
2014-08-26 17:40 ` Junio C Hamano
2014-08-26 17:43 ` Jeff King
2014-08-26 19:25 ` Junio C Hamano
2014-08-26 10:24 ` [PATCH 3/3] log-tree: use FLEX_ARRAY in name_decoration Jeff King
2014-08-27 0:30 ` Eric Sunshine
2014-08-25 21:14 ` Junio C Hamano [this message]
2014-08-26 7:30 ` [PATCH] bisect: save heap memory. allocate only the required amount Arjun Sreedharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd2bol1ad.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=arjun024@gmail$(echo .)com \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox