From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: "Christian Couder" <christian.couder@gmail•com>,
"Arjun Sreedharan" <arjun024@gmail•com>,
git <git@vger•kernel.org>,
"Christian Couder" <chriscool@tuxfamily•org>,
"Nguyễn Thái Ngọc" <pclouds@gmail•com>
Subject: Re: [PATCH] bisect: save heap memory. allocate only the required amount
Date: Mon, 25 Aug 2014 11:26:39 -0700 [thread overview]
Message-ID: <xmqq8umcmnmo.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140825150028.GA28176@peff.net> (Jeff King's message of "Mon, 25 Aug 2014 11:00:28 -0400")
Jeff King <peff@peff•net> writes:
> On Mon, Aug 25, 2014 at 04:06:52PM +0200, Christian Couder wrote:
>
>> > This allocation should be name_len + 1 for the NUL-terminator, no?
>>
>> I wondered about that too, but as struct name_decoration is defined like this:
>>
>> struct name_decoration {
>> struct name_decoration *next;
>> int type;
>> char name[1];
>> };
>>
>> the .name field of this struct already has one char, so the allocation
>> above should be ok.
>
> Yeah, you're right. I would argue it should just be FLEX_ARRAY for
> consistency with other spots, though (in which case add_name_decoration
> needs to be updated with a +1).
>
> Running "git grep '^ char [^ ]*\[[01]]' -- '*.[ch]'" shows that this
> is one of only two spots that don't use FLEX_ARRAY (and the other has a
> comment explaining why not).
Good digging, and I agree that it should use the FLEX_ARRAY for
consistency.
next prev parent reply other threads:[~2014-08-25 18:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-24 14:17 [PATCH] bisect: save heap memory. allocate only the required amount Arjun Sreedharan
2014-08-24 15:10 ` Stefan Beller
2014-08-24 23:39 ` Junio C Hamano
2014-08-25 13:07 ` Jeff King
2014-08-25 21:36 ` Junio C Hamano
2014-08-26 11:03 ` Jeff King
2014-08-26 11:57 ` Ramsay Jones
2014-08-26 12:14 ` Jeff King
2014-08-26 12:37 ` Ramsay Jones
2014-08-26 12:43 ` Jeff King
2014-08-26 12:59 ` Ramsay Jones
2014-08-24 15:32 ` Ramsay Jones
2014-08-24 21:55 ` Arjun Sreedharan
2014-08-25 13:35 ` Jeff King
2014-08-25 14:06 ` Christian Couder
2014-08-25 15:00 ` Jeff King
2014-08-25 18:26 ` Junio C Hamano [this message]
2014-08-25 19:35 ` Jeff King
2014-08-25 20:27 ` Arjun Sreedharan
2014-08-25 21:11 ` Junio C Hamano
2014-08-26 10:20 ` [PATCH 0/3] name_decoration cleanups Jeff King
2014-08-26 10:23 ` [PATCH 1/3] log-tree: make add_name_decoration a public function Jeff King
2014-08-26 11:48 ` Ramsay Jones
2014-08-26 12:17 ` Jeff King
2014-08-26 10:23 ` [PATCH 2/3] log-tree: make name_decoration hash static Jeff King
2014-08-26 17:40 ` Junio C Hamano
2014-08-26 17:43 ` Jeff King
2014-08-26 19:25 ` Junio C Hamano
2014-08-26 10:24 ` [PATCH 3/3] log-tree: use FLEX_ARRAY in name_decoration Jeff King
2014-08-27 0:30 ` Eric Sunshine
2014-08-25 21:14 ` [PATCH] bisect: save heap memory. allocate only the required amount Junio C Hamano
2014-08-26 7:30 ` Arjun Sreedharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8umcmnmo.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=arjun024@gmail$(echo .)com \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox