From: Junio C Hamano <gitster@pobox•com>
To: Quentin Neill <quentin.neill@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v2] blame: add blame.showEmail configuration
Date: Sun, 31 May 2015 11:13:23 -0700 [thread overview]
Message-ID: <xmqqa8wkaa4c.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1433021926-17762-1-git-send-email-qneill@quicinc.com> (Quentin Neill's message of "Sat, 30 May 2015 16:38:46 -0500")
Quentin Neill <quentin.neill@gmail•com> writes:
> From: Quentin Neill <quentin.neill@gmail•com>
>
> Complement existing --show-email option with fallback
> configuration variable, with tests.
> ---
The patch itself looks very reasonable. Thanks for getting back to
us ;-)
A few minor nits:
- Your in-body "From:" is redundant and unnecessary, as your
e-mail is coming from the same address.
- You need "Signed-off-by: Quentin Neill <quentin.neill@gmail•com>"
after your log message (separate it with a blank line before
the sign-off, and place the sign-off before the three-dash
lines).
> diff --git a/t/t8002-blame.sh b/t/t8002-blame.sh
> index 5cdf3f1..faf1660 100755
> --- a/t/t8002-blame.sh
> +++ b/t/t8002-blame.sh
> @@ -19,4 +19,66 @@ test_expect_success 'blame --show-email' '
> "<E at test dot git>" 1
> '
>
> +test_expect_success 'setup showEmail tests' '
> + echo "bin: test number 1" >one &&
> + git add . &&
> + GIT_AUTHOR_NAME=name1 GIT_AUTHOR_EMAIL=email1@test•git git commit -a -m First --date="2010-01-01 01:00:00"
> +'
> +
> +cat >expected_n <<\EOF &&
> +(name1 2010-01-01 01:00:00 +0000 1) bin: test number 1
> +EOF
> +
> +cat >expected_e <<\EOF &&
> +(<email1@test•git> 2010-01-01 01:00:00 +0000 1) bin: test number 1
> +EOF
These two commands outside test_expect_success are part of setup, so
test_expect_success 'setup showEmail tests' '
echo "bin: test number 1" >one &&
git add one &&
GIT_AUTHOR_NAME=name1 \
GIT_AUTHOR_EMAIL=email1@test•git \
git commit -m First --date="2010-01-01 01:00:00" &&
cat >expected_n <<-\EOF &&
(name1 ...
EOF
cat >expected_e <<-\EOF
(<email1@...
EOF
'
Also do not hesitate to break overlong lines with "\".
> +find_blame() {
style: "find_blame () {"
Other than that, the patch looks good.
Thanks.
next prev parent reply other threads:[~2015-05-31 18:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 2:13 [PATCH] blame: add blame.showemail config option Quentin Neill
2015-04-24 5:22 ` Eric Sunshine
2015-04-27 13:46 ` Quentin Neill
2015-04-27 18:10 ` Junio C Hamano
2015-04-27 19:23 ` Eric Sunshine
2015-04-28 7:08 ` Junio C Hamano
2015-04-30 14:03 ` Quentin Neill
2015-04-30 16:10 ` Junio C Hamano
2015-04-30 21:33 ` Eric Sunshine
2015-04-30 21:43 ` Junio C Hamano
2015-04-27 19:57 ` Eric Sunshine
2015-05-29 19:40 ` Junio C Hamano
2015-05-30 20:31 ` Quentin Neill
2015-05-30 21:38 ` [PATCH v2] blame: add blame.showEmail configuration Quentin Neill
2015-05-31 18:13 ` Junio C Hamano [this message]
2015-05-31 19:24 ` Quentin Neill
2015-05-31 19:27 ` [PATCH v3] " Quentin Neill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8wkaa4c.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=quentin.neill@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox